Release v0.1.3

.clang-tidy

@@ -1,6 +1,6 @@
 ---
 Checks: >
-  #disable all ruls first and then enable necessary ones
+  #disable all rules first and then enable necessary ones
     -*,
     -clang-analyzer-apiModeling.StdCLibraryFunctions,
     -clang-analyzer-apiModeling.TrustNonnull,
@@ -27,13 +27,15 @@ Checks: >
     clang-analyzer-cplusplus.InnerPointer,
     clang-analyzer-cplusplus.Move,
     clang-analyzer-cplusplus.NewDelete,
-    clang-analyzer-cplusplus.NewDeleteLeaks,
+    -clang-analyzer-cplusplus.NewDeleteLeaks, # Disabled due to false positives from boost headers
     clang-analyzer-cplusplus.PureVirtualCall,
     clang-analyzer-cplusplus.SelfAssignment,
     clang-analyzer-cplusplus.SmartPtr,
     clang-analyzer-cplusplus.VirtualCallModeling,
     clang-analyzer-deadcode.DeadStores,
     clang-analyzer-fuchsia.HandleChecker,
+    -fuchsia-multiple-inheritance, # We need to fix the occurences and enable
+    fuchsia-virtual-inheritance,
     clang-analyzer-nullability.NullPassedToNonnull,
     clang-analyzer-nullability.NullReturnedFromNonnull,
     clang-analyzer-nullability.NullabilityBase,
@@ -43,7 +45,7 @@ Checks: >
     clang-analyzer-optin.cplusplus.UninitializedObject,
     clang-analyzer-optin.cplusplus.VirtualCall,
     -clang-analyzer-optin.mpi.MPI-Checker,
-    -clang-analyzer-optin.osx.OSObjectCStyleCast,
+    clang-analyzer-optin.osx.OSObjectCStyleCast,
     -clang-analyzer-optin.osx.cocoa.localizability.EmptyLocalizationContextChecker,
     -clang-analyzer-optin.osx.cocoa.localizability.NonLocalizedStringChecker,
     clang-analyzer-optin.performance.GCDAntipattern,
@@ -77,13 +79,45 @@ Checks: >
     clang-analyzer-valist.CopyToSelf,
     clang-analyzer-valist.Uninitialized,
     clang-analyzer-valist.Unterminated,
-    clang-analyzer-valist.ValistBase
+    clang-analyzer-valist.ValistBase,
+    # modernize rules. Need to enable relevant rules incrementally
+    modernize-avoid-bind,
+    -modernize-avoid-c-arrays,
+    -modernize-concat-nested-namespaces,
+    modernize-deprecated-headers,
+    modernize-deprecated-ios-base-aliases,
+    -modernize-loop-convert,
+    modernize-make-shared,
+    modernize-make-unique,
+    modernize-pass-by-value,
+    modernize-raw-string-literal,
+    modernize-redundant-void-arg,
+    modernize-replace-auto-ptr,
+    modernize-replace-disallow-copy-and-assign-macro,
+    modernize-replace-random-shuffle,
+    modernize-return-braced-init-list,
+    modernize-shrink-to-fit,
+    -modernize-unary-static-assert,
+    -modernize-use-auto,
+    modernize-use-bool-literals,
+    modernize-use-default-member-init,
+    modernize-use-emplace,
+    modernize-use-equals-default,
+    modernize-use-equals-delete,
+    -modernize-use-nodiscard,
+    modernize-use-noexcept,
+    modernize-use-nullptr,
+    modernize-use-override,
+    -modernize-use-trailing-return-type,
+    -modernize-use-transparent-functors,
+    modernize-use-uncaught-exceptions,
+    modernize-use-using,
     #
-    -readability-avoid-const-params-in-decls,
+    readability-avoid-const-params-in-decls,
     readability-braces-around-statements,
     readability-const-return-type,
-    -readability-container-size-empty,
-    -readability-convert-member-functions-to-static,
+    readability-container-size-empty,
+    readability-convert-member-functions-to-static,
     readability-delete-null-pointer,
     readability-deleted-default,
     -readability-else-after-return,
@@ -93,7 +127,7 @@ Checks: >
     readability-inconsistent-declaration-parameter-name,
     readability-isolate-declaration,
     -readability-magic-numbers,
-    -readability-make-member-function-const,
+    readability-make-member-function-const,
     readability-misleading-indentation,
     readability-misplaced-array-index,
     readability-named-parameter,
@@ -103,14 +137,14 @@ Checks: >
     readability-redundant-control-flow,
     readability-redundant-declaration,
     readability-redundant-function-ptr-dereference,
-    -readability-redundant-member-init,
+    readability-redundant-member-init,
     readability-redundant-preprocessor,
-    -readability-redundant-smartptr-get,
+    readability-redundant-smartptr-get,
     -readability-redundant-string-cstr,
-    -readability-redundant-string-init,
+    readability-redundant-string-init,
     -readability-simplify-boolean-expr,
     readability-simplify-subscript-expr,
-    -readability-static-accessed-through-instance,
+    readability-static-accessed-through-instance,
     readability-static-definition-in-anonymous-namespace,
     readability-string-compare,
     readability-uniqueptr-delete-release,
@@ -121,23 +155,23 @@ Checks: >
     # bugprone-bad-signal-to-kill-thread,
     # bugprone-bool-pointer-implicit-conversion,
     # bugprone-branch-clone,
-    # bugprone-copy-constructor-init,
+    bugprone-copy-constructor-init,
     # bugprone-dangling-handle,
     # bugprone-dynamic-static-initializers,
     # bugprone-exception-escape,
     # bugprone-fold-init-type,
     # bugprone-forward-declaration-namespace,
-    # bugprone-forwarding-reference-overload,
+    bugprone-forwarding-reference-overload,
     # bugprone-inaccurate-erase,
     # bugprone-incorrect-roundings,
     # bugprone-infinite-loop,
     # bugprone-integer-division,
     # bugprone-lambda-function-name,
-    # bugprone-macro-parentheses,
+    bugprone-macro-parentheses,
     # bugprone-macro-repeated-side-effects,
     # bugprone-misplaced-operator-in-strlen-in-alloc,
     # bugprone-misplaced-widening-cast,
-    # bugprone-move-forwarding-reference,
+    bugprone-move-forwarding-reference,
     # bugprone-multiple-statement-macro,
     # bugprone-narrowing-conversions,
     # bugprone-not-null-terminated-result,
@@ -154,7 +188,7 @@ Checks: >
     # bugprone-suspicious-missing-comma,
     # bugprone-suspicious-semicolon,
     # bugprone-suspicious-string-compare,
-    # bugprone-swapped-arguments,
+    bugprone-swapped-arguments,
     # bugprone-terminating-continue,
     # bugprone-throw-keyword-missing,
     # bugprone-too-small-loop-variable,
@@ -163,7 +197,7 @@ Checks: >
     # bugprone-unhandled-self-assignment,
     # bugprone-unused-raii,
     # bugprone-unused-return-value,
-    # bugprone-use-after-move,
+    bugprone-use-after-move,
     # bugprone-virtual-near-miss,
     #
     cert-dcl03-c,
@@ -204,6 +238,7 @@ Checks: >
     cppcoreguidelines-avoid-c-arrays,
     cppcoreguidelines-avoid-goto,
     -cppcoreguidelines-avoid-magic-numbers,
+    cppcoreguidelines-avoid-non-const-global-variables,
     cppcoreguidelines-c-copy-assignment-signature,
     cppcoreguidelines-explicit-virtual-functions,
     cppcoreguidelines-init-variables,
@@ -220,11 +255,11 @@ Checks: >
     cppcoreguidelines-pro-type-cstyle-cast,
     -cppcoreguidelines-pro-type-member-init, # too many false positive
     -cppcoreguidelines-pro-type-reinterpret-cast,
-    -cppcoreguidelines-pro-type-static-cast-downcast,
+    cppcoreguidelines-pro-type-static-cast-downcast,
     -cppcoreguidelines-pro-type-union-access,
     -cppcoreguidelines-pro-type-vararg,
-    -cppcoreguidelines-slicing,
-    cppcoreguidelines-special-member-functions
+    cppcoreguidelines-slicing,
+    cppcoreguidelines-special-member-functions,
     #
     # google-readability-avoid-underscore-in-googletest-name,
     # google-readability-braces-around-statements,
@@ -238,15 +273,23 @@ Checks: >
     -zircon-temporary-objects
 # Turn all the warnings from the checks above into errors.
 WarningsAsErrors: '*'
-# CheckOptions:
-#   - { key: readability-identifier-naming.NamespaceCase,          value: lower_case }
-#   - { key: readability-identifier-naming.ClassCase,              value: CamelCase  }
-#   - { key: readability-identifier-naming.StructCase,             value: CamelCase  }
-#   - { key: readability-identifier-naming.TemplateParameterCase,  value: CamelCase  }
+CheckOptions:
+  - key:             cppcoreguidelines-special-member-functions.AllowSoleDefaultDtor
+    value:           '1'
+  - key: readability-identifier-naming.NamespaceCase
+    value: CamelCase
+  - key: readability-identifier-naming.ClassCase
+    value: CamelCase
+  - key: readability-identifier-naming.StructCase
+    value: CamelCase
+  - key: readability-identifier-naming.TemplateParameterCase
+    value: CamelCase
+#  - key: readability-identifier-naming.ClassMemberPrefix
+#    value: m
+#  - key: readability-identifier-naming.ClassMemberCase
+#    value: CamelCase
 #   - { key: readability-identifier-naming.FunctionCase,           value: aNy_CasE  }
 #   - { key: readability-identifier-naming.VariableCase,           value: lower_case }
-#   - { key: readability-identifier-naming.ClassMemberCase,        value: lower_case }
-#   - { key: readability-identifier-naming.ClassMemberSuffix,      value: _          }
 #   - { key: readability-identifier-naming.PrivateMemberSuffix,    value: _          }
 #   - { key: readability-identifier-naming.ProtectedMemberSuffix,  value: _          }
 #   - { key: readability-identifier-naming.EnumConstantCase,         value: CamelCase }

.github/ISSUE_TEMPLATE/bug_report.md

@@ -0,0 +1,30 @@
+---
+name: Bug report
+about: Create a report to help us improve
+title: ''
+labels: ''
+assignees: ''
+
+---
+
+**Describe the bug**
+A clear and concise description of what the bug is.
+
+Note: If you discover a potential security issue in this project we ask that you notify AWS/Amazon
+Security via our vulnerability reporting page. Please do not create a public github issue.
+
+**To Reproduce**
+Steps to reproduce the behavior.
+
+**Expected behavior**
+A clear and concise description of what you expected to happen.
+
+**Logs**
+Please attach the log output if available.
+
+**Environment (please complete the following information):**
+ - OS: [e.g. Linux kernel version]
+ - Version [e.g. v0.1.0]
+
+**Additional context**
+Add any other context about the problem here.

.github/ISSUE_TEMPLATE/feature_request.md

@@ -0,0 +1,20 @@
+---
+name: Feature request
+about: Suggest an idea for this project
+title: ''
+labels: ''
+assignees: ''
+
+---
+
+**Is your feature request related to a problem? Please describe.**
+A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
+
+**Describe the solution you'd like**
+A clear and concise description of what you want to happen.
+
+**Describe alternatives you've considered**
+A clear and concise description of any alternative solutions or features you've considered.
+
+**Additional context**
+Add any other context about the feature request here.

.github/workflows/ci.yml

@@ -43,7 +43,7 @@ jobs:
       run: |
         cd build
         # Exclude tests that require SocketCAN
-        CTEST_OUTPUT_ON_FAILURE=1 ctest -E "IoTFleetWiseEngineTest|NetworkChannelBinderTest|OBDOverCANModuleTest|ISOTPOverCANProtocolTest|SocketCANBusChannelTest"
+        CTEST_OUTPUT_ON_FAILURE=1 ctest
 
     - name: upload-artifacts
       uses: actions/upload-artifact@v2

CHANGELOG.md

@@ -1,5 +1,32 @@
 # Change Log
 
+## v0.1.3 (Aug 3, 2022)
+https://s3.console.aws.amazon.com/s3/object/aws-iot-fleetwise?prefix=v0.1.3/aws-iot-fleetwise-edge.zip
+
+Customer Demo:
+* Updated demo scripts to match with latest AWS IoT FleetWise Cloud [API changes](https://docs.aws.amazon.com/iot-fleetwise/latest/developerguide/update-sdk-cli.html)
+* Fix a bug in demo script that might render scatter plot incorrectly. 
+
+Docs:
+* Updated the Edge Agent Developer Guide to match with latest AWS IoT FleetWise Cloud [API changes](https://docs.aws.amazon.com/iot-fleetwise/latest/developerguide/update-sdk-cli.html)
+* Updated Security Best Practices in Edge Agent Developer Guide
+
+Bugfixes:
+* Fixed a bug which previously prevented OBD from functioning at 29-bit mode.
+* Fixed a bug that potentially caused a crash when two collection schemes were using the same
+  Signal Ids in the condition with different minimum sampling intervals
+
+Improvements:
+* Signal Ids sent over Protobuf from the cloud can now be spread across the whole 32 bit range,
+  not only 0-50.000
+* Security improvement to pass certificate and private key by content rather than by file path
+* Improvement to Google test CMake configuration
+* Clang tidy coverage improvements
+* Improvement to AWS SDK memory allocation with change to custom thread-safe allocator
+* Re-organized code to remove cycles among CMake library targets
+* Refactored Vehicle Network module to improve extensibility for other network types
+* Improvement to cansim to better handle ISO-TP error. 
+
 ## v0.1.2 (February 24, 2022)
 https://s3.console.aws.amazon.com/s3/object/aws-iot-fleetwise?prefix=v0.1.2/aws-iot-fleetwise-edge.zip
 

CMakeGraphVizOptions.cmake

@@ -0,0 +1 @@
+set(GRAPHVIZ_IGNORE_TARGETS "Gtest;Test;fuzz")

CMakeLists.txt

@@ -2,10 +2,11 @@
 
 cmake_minimum_required(VERSION 3.10.2)
 
-project(iotfleetwise VERSION 0.1.2)
+project(iotfleetwise VERSION 0.1.3)
 
-# Due to autosar rules, AWS IoT FleetWise Edge will use C++11
-set(CMAKE_CXX_STANDARD 11)
+# AWS IoT FleetWise Edge uses C++14 for compatibility reasons with 
+# Automotive middlewares ( Adaptive AUTOSAR, ROS2)
+set(CMAKE_CXX_STANDARD 14)
 set(CMAKE_CXX_STANDARD_REQUIRED True)
 
 message(STATUS "Hello from the AWS IoT FleetWise build system!")
@@ -31,6 +32,7 @@ if(NOT CMAKE_BUILD_TYPE)
   set(CMAKE_BUILD_TYPE Release)
 endif()
 
+include(CMakeGraphVizOptions.cmake)
 include(cmake/compiler_gcc.cmake)
 include(cmake/protobufs.cmake)
 if(FWE_FEATURE_CAMERA)
@@ -39,6 +41,7 @@ if(FWE_FEATURE_CAMERA)
 endif()
 include(cmake/snappy.cmake)
 include(CTest)
+include(cmake/unit_test.cmake)
 include(cmake/valgrind.cmake)
 include(cmake/clang_tools.cmake)
 include(cmake/clang_tidy.cmake)
@@ -47,3 +50,6 @@ if(FWE_BUILD_DOC)
 endif()
 
 add_subdirectory(src)
+
+# Disallow cycles
+set_property( GLOBAL PROPERTY GLOBAL_DEPENDS_NO_CYCLES ON )

CODE_OF_CONDUCT.md

@@ -0,0 +1,4 @@
+## Code of Conduct
+This project has adopted the [Amazon Open Source Code of Conduct](https://aws.github.io/code-of-conduct).
+For more information see the [Code of Conduct FAQ](https://aws.github.io/code-of-conduct-faq) or contact
+[email protected] with any additional questions or comments.