Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: support log item attributes and change visibility for item attribute #43

Merged
merged 2 commits into from
Dec 15, 2023

Conversation

zhu-xiaowei
Copy link
Contributor

Description

  1. support log items
  2. change item attribute visibility and add document

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds using Swift Package Manager
  • All unit tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@zhu-xiaowei zhu-xiaowei added the enhancement New feature or request label Dec 13, 2023
@zhu-xiaowei zhu-xiaowei requested a review from zxkane December 13, 2023 08:42
@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (c18458c) 94.72% compared to head (ac6e18d) 94.57%.

Files Patch % Lines
...am/Support/Extension/JsonObject+ToJsonString.swift 77.77% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #43      +/-   ##
==========================================
- Coverage   94.72%   94.57%   -0.16%     
==========================================
  Files          35       35              
  Lines        1935     1934       -1     
==========================================
- Hits         1833     1829       -4     
- Misses        102      105       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zxkane zxkane changed the title feat: support log item attributes and change visibility for item attribute chore: support log item attributes and change visibility for item attribute Dec 14, 2023
@zxkane zxkane merged commit 3287e77 into main Dec 15, 2023
4 checks passed
@zxkane zxkane deleted the optimize_item branch December 15, 2023 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants