fix: repo info for Gitlab does not support group nesting #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.
git-util.tsto support hosting Harmonix reference repositories in a nested Gitlab groupGitlabApi::getFileContents(parse base 64) andGitlabApi::commitContent(redundant json() call)Motivation
We are working on integrating Harmonix in an existing Backstage and GitLab environment. Everything went surprisingly fine with installing/integrating the plugins and hosting Harmonix templates, but we are encountering an issue when deleting resources from Backstage.
It seems that it comes from the way repository name and group are computed. This PR aims to correct it to support different nesting levels in GitLab.
GitHub is not impacted because deep nesting is not possible (it is always organization/repo) but I thought it would be better to unify how these informations are queried.
For Moderators
Additional Notes