Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(axelarnet)!: retry failed transfer #2203

Merged
merged 6 commits into from
Nov 7, 2024

Conversation

haiyizxx
Copy link
Contributor

Description

Todos

  • Unit tests
  • Manual tests
  • Documentation
  • Connect epics/issues
  • Tag type of change
  • Upgrade handler

Steps to Test

Expected Behaviour

Other Notes

@haiyizxx haiyizxx force-pushed the AXE-6259-Fix-IBC-transfer-retry-logic branch 2 times, most recently from df5f5ea to 8f4ffdd Compare October 31, 2024 18:50
@haiyizxx haiyizxx marked this pull request as ready for review October 31, 2024 18:54
@haiyizxx haiyizxx requested a review from a team as a code owner October 31, 2024 18:54
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 49.35065% with 39 lines in your changes missing coverage. Please review.

Project coverage is 39.32%. Comparing base (d8e91da) to head (52ed933).

Files with missing lines Patch % Lines
x/axelarnet/keeper/migrate.go 55.00% 12 Missing and 6 partials ⚠️
x/axelarnet/types/mock/expected_keepers.go 52.17% 10 Missing and 1 partial ⚠️
x/axelarnet/keeper/msg_server.go 33.33% 4 Missing and 2 partials ⚠️
x/axelarnet/module.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2203      +/-   ##
==========================================
+ Coverage   39.25%   39.32%   +0.07%     
==========================================
  Files         374      374              
  Lines       37302    37369      +67     
==========================================
+ Hits        14642    14696      +54     
- Misses      21724    21728       +4     
- Partials      936      945       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@haiyizxx haiyizxx force-pushed the AXE-6259-Fix-IBC-transfer-retry-logic branch from 8f4ffdd to 1f8d017 Compare October 31, 2024 19:10
x/axelarnet/keeper/migrate.go Outdated Show resolved Hide resolved
x/axelarnet/keeper/migrate.go Outdated Show resolved Hide resolved
x/axelarnet/keeper/msg_server.go Outdated Show resolved Hide resolved
@haiyizxx haiyizxx added the next release Required for the next release label Nov 6, 2024
x/axelarnet/keeper/migrate.go Show resolved Hide resolved
x/axelarnet/keeper/migrate.go Show resolved Hide resolved
@haiyizxx haiyizxx merged commit 8fa58f2 into main Nov 7, 2024
6 of 7 checks passed
@haiyizxx haiyizxx deleted the AXE-6259-Fix-IBC-transfer-retry-logic branch November 7, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next release Required for the next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants