Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the typing_extensions dependency #1992

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

AdeelH
Copy link
Collaborator

@AdeelH AdeelH commented Nov 17, 2023

Overview

This PR removes the typing_extensions dependency since it is no longer needed.

It was only used for the Literal type, but its Literal type is identical to typing.Literal for newer versions of Python.

Checklist

  • Added unit tests, if applicable
  • Updated documentation, if applicable
  • Added needs-backport label if the change should be back-ported to the previous release
  • PR has a name that won't get you publicly shamed for vagueness

Notes

N/A

Testing Instructions

N/A

Copy link

codecov bot commented Nov 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d173194) 86.20% compared to head (0054b3d) 86.19%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1992      +/-   ##
==========================================
- Coverage   86.20%   86.19%   -0.01%     
==========================================
  Files         195      195              
  Lines        9627     9621       -6     
==========================================
- Hits         8299     8293       -6     
  Misses       1328     1328              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AdeelH AdeelH merged commit b312579 into azavea:master Nov 17, 2023
1 check passed
@AdeelH AdeelH deleted the typing-extensions branch November 17, 2023 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant