Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add azurerm_portal_dashboard #258

Merged
merged 3 commits into from
Jan 11, 2024
Merged

Add azurerm_portal_dashboard #258

merged 3 commits into from
Jan 11, 2024

Conversation

rfernandezdo
Copy link
Contributor

@rfernandezdo rfernandezdo commented Oct 9, 2023 •
edited
Loading

Issue-id

PR Checklist

  • I have read the CONTRIBUTING.MD instructions
  • I have changed the resourceDefinition.json
  • I have generated the resource model (there's a models_generated.go file in my PR)
  • I have updated the README.md#resource-status
  • I have checked to ensure there aren't other open Pull Requests for the same update/change?

Description

azurerm_portal_dashboard support added like azurerm_dashboard

Does this introduce a breaking change

  • YES
  • NO

Testing

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@arnaudlh arnaudlh self-requested a review January 11, 2024 03:18
@arnaudlh arnaudlh added the enhancement New feature or request label Jan 11, 2024
@arnaudlh arnaudlh changed the title azurerm_portal_dashboard added Add azurerm_portal_dashboard Jan 11, 2024
@arnaudlh arnaudlh linked an issue Jan 11, 2024 that may be closed by this pull request
Support for azurerm_portal_dashboard #257
Closed
@arnaudlh arnaudlh added this to the 1.2.27 milestone Jan 11, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

arnaudlh
arnaudlh approved these changes Jan 11, 2024
View reviewed changes
Copy link
Member

@arnaudlh arnaudlh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arnaudlh arnaudlh merged commit db30ecc into aztfmod:main Jan 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnaudlh arnaudlh arnaudlh approved these changes

Assignees

@rfernandezdo rfernandezdo

Labels
enhancement New feature or request
Projects
2401
Status: Done
Milestone
1.2.27
Development

Successfully merging this pull request may close these issues.

Support for azurerm_portal_dashboard
2 participants
@rfernandezdo @arnaudlh