Ignore missing deps file in neil new
#242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borkdude
reviewed
Oct 13, 2024
borkdude
reviewed
Oct 13, 2024
- add a minimal template from a local root for use in the test - add test that checks the write to deps file, when it exists and when it doesn't
|
Good for merge now it seems? |
|
Yep - I've got everything in that I'm aiming for. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #241
Change Summary
neil newoutput doesn't contain a deps file to update, do nothing (instead of throwing)assoc-project-meta!Change Detail(s) by file
bb.edn- thecitask appears to call outdated(?) task names, so these are changed to run all the tasks describe in the Actions workflowsneil- updated just based on the run ofgen-script- includes some changes that appear not have not been generated from prior commitsnew.clj- only callassoc-project-meta!if the deps file exists in the directory created byneil newdep_add_test.clj- newer version of clojure expected in testNotes
might want to add the other test namespaces to test_runner, or maybe switch to using cognitect test runner... I didn't want to increase the scope of this change too much
This PR corresponds to an issue with a clear problem statement.
I have updated the CHANGELOG.md file with a description of the addressed issue.
I have considered whether I should add more tests covering the code I've changed.