scripts/bindhosts: better stdout for cron feature

backslashxx · Dec 16, 2024 · c66d241 · c66d241
1 parent 84f0c68
commit c66d241
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/module/bindhosts.sh b/module/bindhosts.sh
@@ -88,15 +88,18 @@ enable_cron() {
 		echo "[+] running crond"
 		busybox crond -bc $PERSISTENT_DIR/crontabs -L /dev/null
 	}
-	echo "[+] adding crontab entry"
 	echo "0 4 * * * sh /data/adb/modules/bindhosts/bindhosts.sh --force-update > $rwdir/bindhosts_cron.log 2>&1 &" | busybox crontab -c $PERSISTENT_DIR/crontabs -
+	echo "[>] $(head -n1 $PERSISTENT_DIR/crontabs/root) " 
+	echo "[+] crontab entry added!"
 }
 
 disable_cron() {
 	if grep -q "bindhosts.sh" $PERSISTENT_DIR/crontabs/root > /dev/null 2>&1; then
-		echo "[ ] removing crontab entry"
-		echo "[ ] $(head -n1 $PERSISTENT_DIR/crontabs/root) " 
+		echo "[>] $(head -n1 $PERSISTENT_DIR/crontabs/root) " 
+		# todo: find a way to kill busybox crond
+		# with just toybox ps
 		rm -rf $PERSISTENT_DIR/crontabs
+		echo "[x] crontab entry removed!"
 	else
 		echo "[x] no crontab entry found!"
 	fi