Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renew [Mastodon] docs and improve parameter handling #10789

Merged
merged 4 commits into from
Jan 5, 2025

Conversation

cyb3rko
Copy link
Contributor

@cyb3rko cyb3rko commented Jan 5, 2025

It's me again 👋

I updated the docs to reflect the new ID lookup method from #4492.

Furthermore the domain parameter is now handled and documented as a domain and not as an URL anymore, because that's how it should be.
To be exact, the parameter should be called fqdn, as subdomains are also allowed, but that would be a breaking change.

And don't worry, to not break existing badges URLs are still accepted and "converted" to domains.


Closes #4492

Copy link
Contributor

github-actions bot commented Jan 5, 2025

Messages
📖 ✨ Thanks for your contribution to Shields, @cyb3rko!

Generated by 🚫 dangerJS against 6358dc2

@chris48s chris48s added this pull request to the merge queue Jan 5, 2025
Merged via the queue into badges:master with commit 41d072e Jan 5, 2025
23 checks passed
@cyb3rko cyb3rko deleted the mastodon branch January 5, 2025 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mastodon user ID lookup methods not working
2 participants