Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add on before view will disappear in view presentation events handling #738

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jrcmramos-bumble
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Dec 10, 2021

Codecov Report

Merging #738 (9df50e6) into master (c13be33) will increase coverage by 0.08%.
The diff coverage is 0.00%.

❗ Current head 9df50e6 differs from pull request most recent head 643d972. Consider uploading reports for the commit 643d972 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #738      +/-   ##
==========================================
+ Coverage   54.78%   54.86%   +0.08%     
==========================================
  Files         108      108              
  Lines        5741     5743       +2     
==========================================
+ Hits         3145     3151       +6     
+ Misses       2596     2592       -4     
Impacted Files Coverage Δ
...ources/ChatController/BaseChatViewController.swift 62.74% <0.00%> (-0.50%) ⬇️
...oller/InputBar/ChatInputBarPresenterProtocol.swift 0.00% <ø> (ø)
...Chat Items/TextMessages/Views/TextBubbleView.swift 85.63% <0.00%> (+3.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c13be33...643d972. Read the comment docs.

@jrcmramos-bumble jrcmramos-bumble changed the title Add on before view will appear in view presentation events handling Add on before view will disappear in view presentation events handling Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants