Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: redeem invite manually or with api key #616

Merged
merged 6 commits into from
Dec 5, 2024
Merged

Conversation

waddaboo
Copy link
Contributor

@waddaboo waddaboo commented Dec 4, 2024

Description

This PR introduces a new feature for users to redeem their invitation code manually or with their api key.

This new feature is available at api and api-sdk.

(This feature was originally in PR #608 but was ported out so that it could be used earlier.)

Related Issue

Does this introduce a breaking change?

  • Yes
  • No

Other information

Sample usage:
API

await invitesService.redeemInviteWithApiKey(
    invite.code,
    groupId,
    admin.apiKey
)

await invitesService.redeemInviteKeyManually(
    invite.code,
    groupId,
    admin.id
)

API SDK

const groupId = "10402173435763029700781503965100"
const inviteCode = "C5VAG4HD"

const invite = await apiSdk.redeemInvite(inviteCode, groupId)

Copy link

vercel bot commented Dec 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bandada-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 5, 2024 2:58pm
bandada-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 5, 2024 2:58pm

@waddaboo waddaboo marked this pull request as ready for review December 4, 2024 11:07
@waddaboo waddaboo requested a review from vplasencia December 4, 2024 11:07
Copy link
Member

@vplasencia vplasencia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you very much @waddaboo

I just left some comments.

libs/api-sdk/README.md Outdated Show resolved Hide resolved
apps/docs/docs/api-sdk.md Outdated Show resolved Hide resolved
apps/api/src/app/invites/invites.service.ts Outdated Show resolved Hide resolved
waddaboo and others added 2 commits December 5, 2024 22:35
@waddaboo waddaboo requested a review from vplasencia December 5, 2024 14:37
Copy link
Member

@vplasencia vplasencia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @waddaboo! Please, just run yarn prettier:write and push the changes and the PR is ready to be merged.

Copy link
Member

@vplasencia vplasencia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @waddaboo 🚀

@vplasencia vplasencia merged commit 68df316 into dev Dec 5, 2024
5 checks passed
@waddaboo waddaboo deleted the feat/redeem-invite branch December 6, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants