Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add redirect uri to getMultipleCredentialsGroupJoinUrl #629

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

waddaboo
Copy link
Contributor

Description

This PR introduces a new feature that gives users the option to include a redirect uri in getMultipleCredentialsGroupJoinUrl.

Developers can use this feature to redirect their users to a specific URL after successfully joining a multiple credential group.

Related Issue

Closes #627

Does this introduce a breaking change?

  • Yes
  • No

@waddaboo waddaboo requested a review from vplasencia December 11, 2024 15:59
Copy link

vercel bot commented Dec 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bandada-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 3:59pm
bandada-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 3:59pm

Copy link
Member

@vplasencia vplasencia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Thank you very much for the PR.

Is this feature working for you properly when you want to redirect to a specific URL?

I think this issue should also be solved in the infrastructure (dashboard and API)

@waddaboo
Copy link
Contributor Author

Ah right, I only updated the API SDK and not the infrastructure, sorry. Will work on it now!

@waddaboo waddaboo marked this pull request as draft December 12, 2024 13:04
@waddaboo waddaboo marked this pull request as ready for review December 17, 2024 08:05
@waddaboo waddaboo requested a review from vplasencia December 17, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants