Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: correction CSS Typos and Remove Duplicate Rules #1278

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

rebustron
Copy link

This pull request addresses the following issues:

Typographical Errors

  • Corrected the --search-font-weight variable in root.css from 16px to 400.
  • Removed the invalid display: auto; property from .scrollbar::-webkit-scrollbar in global.css, as display does not accept auto as a value.

Duplicate CSS Rules

  • Eliminated redundant .feature class definitions in custom.css to maintain a single, consistent rule set.

Notes to Reviewers

  • Please verify that the corrected --search-font-weight value aligns with the intended design specifications.
  • Confirm that the removal of duplicate .feature rules does not affect the styling of elements utilizing this class.

Copy link

vercel bot commented Nov 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-base-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 18, 2025 11:02am

Copy link

vercel bot commented Nov 21, 2024

@rebustron is attempting to deploy a commit to the Coinbase Team on Vercel.

A member of the Team first needs to authorize it.

@cb-heimdall
Copy link
Collaborator

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@wbnns
Copy link
Member

wbnns commented Dec 6, 2024

@rebustron

Thanks for contributing to Base! Confirming this is in our backlog, pending to be reviewed.

@rebustron
Copy link
Author

Hi @zencephalon! Pls check this PR

@wbnns wbnns added base web review To be reviewed by the Base web team and removed community contribution labels Dec 19, 2024
@rebustron
Copy link
Author

Hi @wbnns ! Pls check this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
base web review To be reviewed by the Base web team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants