Allow downstream projects configs to be file_config #1778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 95fede7.
|
A test run succeeded at https://buildkite.com/bazel/bazel-at-head-plus-disabled/builds/1854#_ |
Tweak repo root name Expand env vars Fetch the repo also in project_pipeline
Fixes culprit_finder Fixes culprit_finder and auto sheriff Fixes bazel_bench Rename capture_stdout to suppress_stdout
meteorcloudy
force-pushed
the
downstream_config
branch
from
b99b433 to
1c38073
Compare
fweikert
reviewed
Nov 10, 2023
fweikert
approved these changes
Nov 10, 2023
meteorcloudy
added a commit
that referenced
this pull request
Nov 13, 2023
It should fallback to the default value `None` when suppress_stdout is false This should restore the missing test summary starting from https://buildkite.com/bazel/bazel-bazel/builds/25524 which is right after #1778 was merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reapply #1776 with fixes:
file_configat the correct commit.downstream-rootso that we don't need to get platform info from task config for cloning the repo, which introduces a chicken-egg problem.clone_git_repositoryso that it won't impact stdout ofproject_pipelinevalidate_configalso work for downstream projects by addinggit_commitas a parameter ofget_modified_files.