Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: prefer python_version attribute for specifying python version #2565

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

JeroenSchmidt
Copy link

@JeroenSchmidt JeroenSchmidt commented Jan 16, 2025

This PR is updating the Examples and Docs relating to the recent changes refactor: fold per-target python version into base rules introduced in v.1.1.0.

See the brief conversation between myself and @rickeylev in this diff 611eda8

Copy link

google-cla bot commented Jan 16, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@rickeylev
Copy link
Collaborator

Thanks! This looks pretty good overall. I'll send a few comments shortly.

Before we can accept the PR, though, you'll need to sign the CLA. https://cla.developers.google.com has instructions as to how. If you have already and the tool is mis-reporting, let me know, and I can force it to rescan.

Copy link
Collaborator

@rickeylev rickeylev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few typo corrections and minor word smithing, otherwise LGTM.

Just waiting for the CLA.

docs/_includes/py_console_script_binary.md Outdated Show resolved Hide resolved
docs/_includes/py_console_script_binary.md Outdated Show resolved Hide resolved
docs/_includes/py_console_script_binary.md Outdated Show resolved Hide resolved
docs/toolchains.md Outdated Show resolved Hide resolved
docs/toolchains.md Outdated Show resolved Hide resolved
docs/toolchains.md Outdated Show resolved Hide resolved
docs/toolchains.md Outdated Show resolved Hide resolved
docs/toolchains.md Outdated Show resolved Hide resolved
docs/_includes/py_console_script_binary.md Outdated Show resolved Hide resolved
docs/_includes/py_console_script_binary.md Outdated Show resolved Hide resolved
@rickeylev rickeylev changed the title docs: Docs & Examples for fold per-target python version into base rules docs: prefer python_version attribute for specifying python version Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants