-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: prefer python_version attribute for specifying python version #2565
base: main
Are you sure you want to change the base?
docs: prefer python_version attribute for specifying python version #2565
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Thanks! This looks pretty good overall. I'll send a few comments shortly. Before we can accept the PR, though, you'll need to sign the CLA. https://cla.developers.google.com has instructions as to how. If you have already and the tool is mis-reporting, let me know, and I can force it to rescan. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few typo corrections and minor word smithing, otherwise LGTM.
Just waiting for the CLA.
This PR is updating the Examples and Docs relating to the recent changes
refactor: fold per-target python version into base rules
introduced in v.1.1.0.See the brief conversation between myself and @rickeylev in this diff 611eda8