fix(FSADT1-1641)!: partial update using json-patch #1391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated the DTO to segregate data a bit better - Added new information dto - Added a new exception for partial change - Updated reference code to use the new dtos - Added json patch dependency - Added initial code for partial update
- Updated class names - Moved code to a utils file (PatchUtils.java) - Implemented contact partial update
- Added id to contact dto - Updated patch exception - Updated contact repository - Updated location repository - Updated contact patch service (see below) - Added Location patch service - Added Contact to Location association service The contact patch service will not handle contact association. It can handle add, remove and update of contact and it is marked to run right after the basic details information. The contact location patch service will handle the location association, as this is almost like creating and removing contact, as it should do the same due to the way oracle handles the association.
- Tests are still failing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In order to make the newly updated edit screen more modular, we're using the JSON Patch approach, where we will send only what has changed to the backend in the form of a PATCH request. This should allow the backend to react based only on what's changed, applying the change on top of the existing data.
Type of change
How Has This Been Tested?
Checklist
Further comments
Thanks for the PR!
Deployments, as required, will be available below:
Any successful deployments (not always required) will be available here
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in:
Thanks for the PR!
Deployments, as required, will be available below:
Any successful deployments (not always required) will be available here
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in: