Upgrade for beancount3/beangulp fixes #135 #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarioch
force-pushed
the
feature/beancount_3
branch
6 times, most recently
from
09dba77 to
e40b674
Compare
|
@yagebu would you mind reviewing please, I did now some testing with plain cli as well as going through fava and seems to work fine for my setup. |
tarioch
changed the title
tarioch
force-pushed
the
feature/beancount_3
branch
from
e40b674 to
8828038
Compare
|
will try to take a look in the coming days, yes |
yagebu
force-pushed
the
feature/beancount_3
branch
from
7e222ad to
100bcae
Compare
yagebu
reviewed
Jan 3, 2025
There was a problem hiding this comment.
I've added a commit with some more complete type annotations, that helped me validate the changes. Also, in the hooks, I've added a call to wrap the importer with Adapter to support "old" importers. With that change, my personal importers worked fine in Fava.
yagebu
force-pushed
the
feature/beancount_3
branch
from
88ba13c to
9dae2e5
Compare
|
Should we adjust the date, merge and then release? |
yagebu
force-pushed
the
feature/beancount_3
branch
from
62abde9 to
0d3f98b
Compare
|
Done :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.