Add ability to multiselect groups #1559
Conversation
There was a problem hiding this comment.
Something appears to not be quite right when including "No group" in the filter" + another group. If I save that filter and reopen the app, only "No group" is checked. If I then tap to include the other group in the filter, only the entries in that other group are shown, the "No group" chip remains checked but the entries without a group vanish.
michaelschattgen
force-pushed
the
feature/multiselect-groups
branch
4 times, most recently
from
9fcc064 to
c9a4e77
Compare
There was a problem hiding this comment.
Noticed another issue:
- Have a bunch of entries (one entry in a "Test" group)
- Filter on the "Test" group
- Tap "No group" to add it to the filter
- Tap "Test" to remove it from the filter
- Tap "No group" to remove it from the filter
- Tap "Test" to add it to the filter
- Result: All entries are shown instead of just the entry in the "Test" group
michaelschattgen
force-pushed
the
feature/multiselect-groups
branch
from
c9a4e77 to
fd0dcaf
Compare
michaelschattgen
force-pushed
the
feature/multiselect-groups
branch
from
1584f4f to
fd0dcaf
Compare
michaelschattgen
force-pushed
the
feature/multiselect-groups
branch
from
fd0dcaf to
957cc01
Compare
|
Latest push also fixed a bug where a saved single selection groupfilter was not being displayed properly upon launching the app. |
There was a problem hiding this comment.
It looks like saved filters are not applied on startup: https://alexbakker.me/u/tn6w0snc89.webm
| if (chip.getTag() == "save") { | ||
| return null; | ||
| } | ||
|
|
There was a problem hiding this comment.
If I remember correctly we no longer need this, right?
| @@ -352,6 +349,7 @@ private void addSaveChip(ChipGroup chipGroup) { | |||
| chip.setTextColor(MaterialColors.getColor(chip.getRootView(), com.google.android.material.R.attr.colorSecondary)); | |||
| chip.setClickable(true); | |||
| chip.setCheckedIconVisible(false); | |||
| chip.setTag("save"); | |||
There was a problem hiding this comment.
If I remember correctly we no longer need this, right?
michaelschattgen
force-pushed
the
feature/multiselect-groups
branch
from
957cc01 to
fd0dcaf
Compare
michaelschattgen
force-pushed
the
feature/multiselect-groups
branch
from
fd0dcaf to
78ee38b
Compare
This PR adds a toggle to allow multi selection of groups in the main activity as requested in #1555.
Fixes #1555