Add haptic feedback toggle for code refresh #1599
Conversation
| public void onAnimationEnd(Animator animation) { | ||
| if (!_nonUniform) { | ||
| if (itemView.isShown()) { | ||
| VibrationHelper.vibratePattern(itemView.getContext(), VibrationPatterns.EXPIRING); |
There was a problem hiding this comment.
This results in starting a vibration for every single entry.
Since we're not relying on repeated animation callbacks for the "ticks" of the vibration, I don't think we need to link this to the animation. Perhaps a second postDelayed in UiRefresher would do the trick? This would also make the vibrations work in case animations are disabled, which is currently not the case.
| @@ -144,6 +146,10 @@ public int getSpanSize(int position) { | |||
| @Override | |||
| public void onRefresh() { | |||
| refresh(false); | |||
|
|
|||
| if (_recyclerView.isShown()) { | |||
| VibrationHelper.vibratePattern(getContext(), VibrationPatterns.REFRESH_CODE); | |||
There was a problem hiding this comment.
I'm not sure if this is only the case on my device, but I don't feel this vibration.
| } | ||
|
|
||
| public static boolean isHapticFeedbackEnabled(Context context) { | ||
| Preferences _prefs = EarlyEntryPoints.get(context.getApplicationContext(), PrefEntryPoint.class).getPreferences(); |
There was a problem hiding this comment.
This isn't really what EarlyEntryPoints is meant for. I would suggest simply initializing a new Preferences based on the context. If it turns out we can move the vibration trigger to UiRefresher, we can do this once in the constructor of VibrationHelper.
| @@ -23,7 +23,6 @@ public void start() { | |||
| } | |||
| _running = true; | |||
|
|
|||
| _listener.onRefresh(); | |||
There was a problem hiding this comment.
Are we sure we can remove this?
This PR adds the ability to enable/disable haptic feedback when the codes are about to expire or when they refresh.