Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameterize minimum iOS support version. #43

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Conversation

freakboy3742
Copy link
Member

@freakboy3742 freakboy3742 commented Jan 2, 2025

The iOS template hard-codes 12.0 as the minimum iOS support version; this is now inconsistent with the iOS support package, which uses 13.0.

Rather than hard-code the update, I've parameterised the update, which means it will be possible to override in a user's project.

This should be backported to the 0.3.20 release, as it affects that version as well.

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@freakboy3742 freakboy3742 requested a review from mhsmith January 2, 2025 01:52
@mhsmith mhsmith merged commit ddadae0 into main Jan 6, 2025
6 checks passed
@freakboy3742 freakboy3742 deleted the ios-min-version branch January 6, 2025 23:24
@freakboy3742
Copy link
Member Author

I have also backported this to the v0.3.20 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants