Correcting incorrect object init

beldenfox · Jan 6, 2024 · 2599464 · 2599464
1 parent de8bc9b
commit 2599464
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/modules/javafx.graphics/src/main/native-glass/mac/GlassView3D.m b/modules/javafx.graphics/src/main/native-glass/mac/GlassView3D.m
@@ -720,12 +720,14 @@ - (void)setInputMethodEnabled:(BOOL)enabled
 - (void)finishInputMethodComposition
 {
     IMLOG("finishInputMethodComposition called");
+    // Commit text that was in progress
     if (nsAttrBuffer != nil && nsAttrBuffer.length != 0) {
         NSString* string = nsAttrBuffer.string;
         [_delegate notifyInputMethod:string attr:4 length:string.length cursor:string.length selectedRange: NSMakeRange(NSNotFound, 0)];
     }
-    [nsAttrBuffer initWithString:@""];
+    // End composition phase
     [self.inputContext discardMarkedText];
+    nsAttrBuffer = [nsAttrBuffer initWithString:@""];
     self->shouldProcessKeyEvent = YES;
 }