Skip to content

Commit

Permalink
[skip-ci] [RF] MultiProcess additions to release notes
Browse files Browse the repository at this point in the history
  • Loading branch information
egpbos authored and guitargeek committed Nov 20, 2024
1 parent fe5edee commit 30504ae
Showing 1 changed file with 11 additions and 0 deletions.
11 changes: 11 additions & 0 deletions README/ReleaseNotes/v634/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ The following people have contributed to this new version:
Guilherme Amadio, CERN/IT,\
Bertrand Bellenot, CERN/EP-SFT,\
Jakob Blomer, CERN/EP-SFT,\
Patrick Bos, Netherlands eScience Center,\
Rene Brun,\
Carsten Burgard, DESY\
Will Buttinger, RAL,\
Expand Down Expand Up @@ -203,6 +204,14 @@ This should have minimal impact on users, since one should usual use Minuit 2 vi

## RooFit Libraries

### Error handling in MultiProcess-enabled fits

The `MultiProcess`-based fitting stack now handles errors during fits.
Error signaling in (legacy) RooFit happens through two mechanisms: `logEvalError` calls and `RooNaNPacker`-enhanced NaN doubles.
Both are now implemented and working for `MultiProcess`-based fits as well.
See [this PR](https://github.com/root-project/root/pull/15797) for more details.
This enables the latest ATLAS Higgs combination fits to complete successfully, and also other fits that encounter NaN values or other expected errors.

### Miscellaneous

* Setting `useHashMapForFind(true)` is not supported for RooArgLists anymore, since hash-assisted finding by name hash can be ambiguous: a RooArgList is allowed to have different elements with the same name. If you want to do fast lookups by name, convert your RooArgList to a RooArgSet.
Expand All @@ -215,6 +224,8 @@ This should have minimal impact on users, since one should usual use Minuit 2 vi

* Fixed a bug where in some circumstances `hadd` would not correctly merge objects in nested folders of a ROOT file.

* `RooFit::MultiProcess`-enabled fitting developer/advanced documentation -- [available through GitHub](https://github.com/root-project/root/blob/master/roofit/doc/developers/test_statistics.md) -- was updated. It now contains the most up to date usage instructions for optimizing load balancing (and hence run speed) using this backend.

### Deprecations

* The `RooStats::MarkovChain::GetAsDataSet` and `RooStats::MarkovChain::GetAsDataHist` functions are deprecated and will be removed in ROOT 6.36. The same functionality can be implemented by calling `RooAbsData::reduce` on the Markov Chain's `RooDataSet*` (obtained using `MarkovChain::GetAsConstDataSet`) and then obtaining its binned clone(for `RooDataHist`).
Expand Down

0 comments on commit 30504ae

Please sign in to comment.