Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert settings commands to Typescript #251

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

Convert settings commands to Typescript #251

wants to merge 10 commits into from

Conversation

BehnH
Copy link
Member

@BehnH BehnH commented Dec 23, 2022

Description

This (finally) converts the settings category to Typescript, and also cleans up the settings category as a whole.

Motivation and Context

Moves closer to full TS conversion.

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@BehnH BehnH marked this pull request as draft December 23, 2022 19:54
@BehnH BehnH self-assigned this Dec 23, 2022
@BehnH BehnH linked an issue Dec 23, 2022 that may be closed by this pull request
Finish Settings command conversion to Typescript #233
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@BehnH BehnH

Labels
meta: cleanup meta: refactor priority: high type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Finish Settings command conversion to Typescript
1 participant
@BehnH