Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rubocop CI taking forever #24

Merged
merged 7 commits into from
Jun 19, 2024
Merged

Fix rubocop CI taking forever #24

merged 7 commits into from
Jun 19, 2024

Conversation

phrdang
Copy link
Member

@phrdang phrdang commented Jun 19, 2024

  • Add .ruby-version file
  • Fixes Investigate rubocop taking too long #22 by excluding spec/ from the jekyll build so that we don't have to exclude _site/ from the rubocop config, which seems to be causing the rubocop CI job to run forever

@phrdang phrdang self-assigned this Jun 19, 2024
phrdang added 6 commits June 18, 2024 20:48
This way it doesn't appear in _site/ and rubocop doesn't yell at *.rb files in _site (so we don't have to exclude it, which is for some reason causing the rubocop action to run forever)
@phrdang phrdang marked this pull request as ready for review June 19, 2024 03:58
@phrdang phrdang merged commit 50ed272 into main Jun 19, 2024
3 of 6 checks passed
@phrdang phrdang deleted the rubocop branch June 19, 2024 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate rubocop taking too long
1 participant