Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add APM32 Serial Device Support #4034

Closed
wants to merge 1 commit into from

Conversation

LuckkMaker
Copy link

Add APM32 Serial Device Support

Description

This merge request introduces support for APM32 serial devices manufactured by Geehy Semiconductor. Specifically, it adds identification and support for devices with a Vendor ID (VID) of 0x314B and a Product ID (PID) of 0x5740.

Changes

  • Updated the serial_devices.js file to include the new device identification information.
  • Added support for devices with Geehy Semiconductor's VID (0x314B) and PID (0x5740).

Purpose

The purpose of this update is to expand our hardware support, enabling our software to be compatible with APM32 series serial devices. This will provide our users with a broader range of hardware options.

Testing

  • Verified the correct update of the serial_devices.js file.
  • Conducted practical tests with an APM32 device having the specified VID and PID to ensure correct identification and functionality.

Betaflight_Configurator_Geehy

Copy link

netlify bot commented Jun 18, 2024

Deploy Preview for origin-betaflight-app ready!

Name Link
🔨 Latest commit b57e31f
🔍 Latest deploy log https://app.netlify.com/sites/origin-betaflight-app/deploys/66711eba9c01e200081a16da
😎 Deploy Preview https://deploy-preview-4034.dev.app.betaflight.com
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@LuckkMaker LuckkMaker marked this pull request as draft June 18, 2024 05:44
@LuckkMaker LuckkMaker marked this pull request as ready for review June 18, 2024 05:53
Copy link
Member

@haslinghuis haslinghuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • APM32 is already recognized as F40X.
  • What udev rules are needed to be able to flash APM32?

image

@nerdCopter
Copy link
Member

  • someone recently added this to another project as well (decimal coded though) -- {'vendorId': 12619, 'productId': 262} // APM32 DFU Bootloader
  • was told it is binary compatible to stm32

@haslinghuis
Copy link
Member

Already have this in 46-stdfu-permission.rules but does not allow flashing.

VendorId: 314b (12619)
ProductId: 106 (262)

@nerdCopter
Copy link
Member

@Alden-wrk
Copy link

Alden-wrk commented Jun 18, 2024

8065cfff31250a09116b96d69b961f4
d3bfc2ba5ad356d91d8588c134a31ca

I am a team with @MorroGeek and we are working on adding the SDK for APM32 to Betaflight and we have now finished the native build and successfully run it on the PCB I designed. Now that we need to merge the added SDK into the main branch, please allow our merge request.

@Alden-wrk
Copy link

@haslinghuis @nerdCopter This Pull requests Merging is blocked,How do I pass this Pull request?

@McGiverGim
Copy link
Member

To merge this PR it needs to be approved by several people. No problem with that, but the firmware part needs to be approved and merged first.
Until then, if someone wants to test it, the netlify link above can be used.

Copy link
Member

@haslinghuis haslinghuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@haslinghuis
Copy link
Member

haslinghuis commented Jun 28, 2024

@MorroGeek this PR is based upon master 🙄

EDIT: made a new PR to fix.

@LuckkMaker
Copy link
Author

@MorroGeek this PR is based upon master 🙄

EDIT: made a new PR to fix.

Excuse me for the oversight with the PR being based on the master branch. I understand the importance of keeping the master branch clean and stable. For the next PR, I will create a new branch for development and submit the PR from there to ensure compliance with Betaflight PR rules.

Thanks for bringing this to my attention, and I appreciate your understanding.

betaflight/betaflight#13709

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

5 participants