-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added saving log headers #48
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afgTheCat
force-pushed
the
saving-log-headers
branch
from
August 27, 2024 07:36
36dc572
to
ed9032d
Compare
@afgTheCat please rebase |
This comment has been minimized.
This comment has been minimized.
@haslinghuis synced with the github tool, not sure if thats acceptable to you |
This comment has been minimized.
This comment has been minimized.
haslinghuis
reviewed
Aug 28, 2024
afgTheCat
force-pushed
the
saving-log-headers
branch
from
August 28, 2024 16:04
de473e9
to
aef4602
Compare
Do you want to test this code? Here you have an automated build: |
haslinghuis
approved these changes
Aug 28, 2024
nerdCopter
approved these changes
Aug 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- approving untested, only visual review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
I don't think there is a way to save the log headers currently. This pr introduces an option to save them. I use this option to work with my logs, lmk if there is a need for this feature/if I should change anything :)