Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

frame_count_diagnostics_plugin.rs is confusingly named #17261

Open
rparrett opened this issue Jan 9, 2025 · 1 comment
Open

frame_count_diagnostics_plugin.rs is confusingly named #17261

rparrett opened this issue Jan 9, 2025 · 1 comment
Labels
A-Diagnostics Logging, crash handling, error reporting and performance analysis C-Bug An unexpected or incorrect behavior C-Code-Quality A section of code that is hard to understand or change D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it!

Comments

@rparrett
Copy link
Contributor

rparrett commented Jan 9, 2025 •
edited
Loading

Bevy version

main

What you did

Noticed that this file provides FrameCountPlugin, not FrameCountDiagnosticsPlugin. It's not a "diagnostic plugin," it is just responsible for updating the FrameCount resource.
@rparrett rparrett added C-Bug An unexpected or incorrect behavior S-Needs-Triage This issue needs to be labelled D-Trivial Nice and easy! A great choice to get started with Bevy C-Code-Quality A section of code that is hard to understand or change A-Diagnostics Logging, crash handling, error reporting and performance analysis S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it! and removed S-Needs-Triage This issue needs to be labelled labels Jan 9, 2025
@IceSentry
Copy link
Contributor

FrameCount is a diagnostic, but it's currently added by the FrameTimeDiagnosticPlugin. I don't know why it's done this way, but it should probably just be moved to the frame count plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Diagnostics Logging, crash handling, error reporting and performance analysis C-Bug An unexpected or incorrect behavior C-Code-Quality A section of code that is hard to understand or change D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rparrett @IceSentry