Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests in bevy_input_focus fail to ru with default feature flags #17263

Open
alice-i-cecile opened this issue Jan 9, 2025 · 1 comment
Open
Labels
A-Input Player input via keyboard, mouse, gamepad, and more A-UI Graphical user interfaces, styles, layouts, and widgets C-Bug An unexpected or incorrect behavior C-Testing A change that impacts how we test Bevy or how users test their apps P-Compile-Failure A failure to compile Bevy apps S-Needs-Investigation This issue requires detective work to figure out what's going wrong

Comments

@alice-i-cecile
Copy link
Member

Bevy version

0a9740c

What you did

Run a unit test in bevy_input_focus from within VSCode, which ran:

cargo test --package bevy_input_focus --lib --all-features -- directional_navigation::tests::looping_grid_edges --exact --show-output 

What went wrong

Compile failure, with:

   Compiling glam v0.29.2
error[E0599]: no function or associated item named `abs` found for type `f32` in the current scope
   --> /home/alice/.cargo/registry/src/index.crates.io-6f17d22bba15001f/glam-0.29.2/src/f32/math.rs:147:14
    |
147 |         f32::abs(f)
    |              ^^^ function or associated item not found in `f32`

And so on.

Additional information

cargo run -p ci works, suggesting that this is a feature flag issue. Adding the libm flag to bevy_math as a dev-dependency fixes this crop of errors, but reveals more deeper down.

@alice-i-cecile alice-i-cecile added A-Input Player input via keyboard, mouse, gamepad, and more A-UI Graphical user interfaces, styles, layouts, and widgets C-Bug An unexpected or incorrect behavior C-Testing A change that impacts how we test Bevy or how users test their apps P-Compile-Failure A failure to compile Bevy apps S-Needs-Investigation This issue requires detective work to figure out what's going wrong labels Jan 9, 2025
@alice-i-cecile
Copy link
Member Author

bitshifter/glam-rs#595 will help with the glam parts of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Input Player input via keyboard, mouse, gamepad, and more A-UI Graphical user interfaces, styles, layouts, and widgets C-Bug An unexpected or incorrect behavior C-Testing A change that impacts how we test Bevy or how users test their apps P-Compile-Failure A failure to compile Bevy apps S-Needs-Investigation This issue requires detective work to figure out what's going wrong
Projects
None yet
Development

No branches or pull requests

1 participant