Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger test suite on pushes to forks. #125

Closed
wants to merge 1 commit into from

Conversation

mooster531
Copy link
Collaborator

on: push apparently does not do that by default, see https://github.com/orgs/community/discussions/50736

@mooster531 mooster531 requested a review from bh2smith December 17, 2024 15:04
@mooster531 mooster531 marked this pull request as ready for review December 17, 2024 15:04
@mooster531 mooster531 force-pushed the trigger-tests-on-prs-from-forks branch from 480d01a to 9206ea4 Compare December 17, 2024 15:05
@bh2smith
Copy link
Owner

We don't want this... because test suites could expose keys.

Scenario:

  • someone forks repo and logs an env var that is set in our github actions secrets.

@mooster531
Copy link
Collaborator Author

We don't want this... because test suites could expose keys.

Scenario:

* someone forks repo and logs an env var that is set in our github actions secrets.

I did not think of that. Sorry, and thanks for pointing out.

@mooster531 mooster531 closed this Dec 17, 2024
@bh2smith bh2smith deleted the trigger-tests-on-prs-from-forks branch December 17, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants