Simplify Main Entry Point #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bh2smith
commented
Oct 26, 2024
|
I'd call it |
|
I think I will go with |
|
All ready for your review. |
bh2smith
added a commit
that referenced
this pull request
Oct 26, 2024
This is based on #29 Adds tests to reach above 80% coverage and workflow that fails if its below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No logical changes have been made here.
Except now there is a new function
def dune_to_postgres(env: Env, job: DuneToLocalJob) -> None:which is called from the main entry point.
I am not terribly fond of the new file name
dune_to_local/main.py- open to suggestions.