-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mostly typo fixes and standardization of Chapter # format. #24
Open
alexandermorgan
wants to merge
16
commits into
bigskysoftware:main
Choose a base branch
from
alexandermorgan:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for magenta-kringle-251500 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for hypermedia-systems ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many thanks for this wonderful book! I wanted to show my appreciation with a simple pr with mostly typo fixes. Each commit is pretty atomic just fixing one thing and the commit message says what the change is. The only systematic change is that the different ways chapters are referenced (Chapter 3, chapter 3, Chapter Three) are normalized to Chapter 3.
There are some other things I noticed that I didn't change in this pr, either because I don't know how to or because it's more debatable. I'll share those things here for your consideration:
This would also require revisiting the <2> and <3> references in the passage above, as well as the reference to "16 lines of backend code" in Chapter 7. Oh and I noticed that your contact-app repo similarly has two loops but that one uses
list(map(...
. That's not better than a single for loop either.2. The urls in the attribution parameters of blockquotes don't parse as links which seems inconsistent for a hypermedia book. E.g. the Ted Nelson quote in Chapter 1.
3. It would be really slick if the footnotes (like those in Chapter 9) displayed the text of the footnote in the way most html elements do with the "title" text. I couldn't tell how to make that work in your setup though.
4. Not a big deal, but the "Apply" button in your "Customize Colors" panel doesn't do anything. Colors get applied as soon as they're selected and pushing the Apply button doesn't even close the panel.
5. Also regarding the color panel, maybe there should be a color picker for the HTML Notes panel background as well. Because if you invert the colors with white text on a black background, the background of those panels doesn't change and white on pale blue is really hard to read.
6. In Chapter 12, the screenshot referred to here seems to have been taken later in the development process. At this point in the book, I don't think we should have the "Edit" button yet. See: #figure([#image("images/screenshot_hyperview_detail_cropped.png")]
7. Also in Chapter 12 you say "the Hyperview client only understands
GET
andPOST
." No mistake per se, but I can't believe it. Did you really limit Hyperview to only GET and POST requests? Why would that be the case?