Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore Spotify support #767

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Restore Spotify support #767

wants to merge 3 commits into from

Conversation

aerz
Copy link

@aerz aerz commented Sep 9, 2023

The system tray indicator is available again.

Flatpak support is not included because the package has not been updated for some time. I could add it by guessing the paths, just an idea.

* appindicator is available again since v1.2.20.1210 and there is a new
directory which contains the icons
@mirenradia
Copy link
Contributor

The flatpak version has been updated recently and the latest versions add a tray icon. Would you be able to add support for it in this PR? The relevant paths on my system are

"app_path": /var/lib/flatpak/app/com.spotify.Client/

and

"icons_path": /var/lib/flatpak/app/com.spotify.Client/current/active/files/extra/share/spotify/icons

Thanks.

@aerz
Copy link
Author

aerz commented Oct 28, 2023

Done! @mirenradia
Thank you for the heads-up.

However, I notice that the conversion changes the icons to the same size for all of them. Any idea on what's going on?

2023-10-28T121947

2023-10-28T122515

I used the following command:

sudo -E hardcode-tray --conversion-tool RSVGConvert --size 22 --theme Papirus

@mirenradia
Copy link
Contributor

Done! @mirenradia
Thank you for the heads-up.

However, I notice that the conversion changes the icons to the same size for all of them. Any idea on what's going on?

2023-10-28T121947

2023-10-28T122515

I used the following command:

sudo -E hardcode-tray --conversion-tool RSVGConvert --size 22 --theme Papirus

What about if you omit the --size 22 argument?

@aerz
Copy link
Author

aerz commented Oct 28, 2023

What about if you omit the --size 22 argument?

Forget it, hardcode-tray works fine. The problem here is Spotify client is only using spotify-linux-32.png for system tray icon but it's not supported. Commented here PapirusDevelopmentTeam/papirus-icon-theme@85def32

@mirenradia
Copy link
Contributor

Hmm, despite changing the relevant icon files (even if I revert the last commit), the icon is still the original one with the Spotify flatpak. I even tried creating a spotify_icon.ico file from the Papirus monochrome SVG but that didn't help either.

@aerz
Copy link
Author

aerz commented Oct 28, 2023

Hmm, despite changing the relevant icon files (even if I revert the last commit), the icon is still the original one with the Spotify flatpak. I even tried creating a spotify_icon.ico file from the Papirus monochrome SVG but that didn't help either.

I tested the user and system installation using Flatpak. It should work following the manual installation steps and using the command I posted before. Did you get any error?

@mirenradia
Copy link
Contributor

I tested the user and system installation using Flatpak. It should work following the manual installation steps and using the command I posted before. Did you get any error?

It does replace the icon files as expected but at least for me the tray icon is still coloured.

@voedev
Copy link

voedev commented Dec 19, 2023

When will the changes be available in the master branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants