Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the ember-cli linting plugins has been deprecated for years based on the RFC linked to below. ember-cli-eslint and ember-cli-template-lint have already been marked deprecated and have deprecation notices in their READMEs as linked to below.
In this PR, I'm proposing/implementing a deprecation notice suggesting to use stylelint directly instead. If this is accepted, the maintainer should also run the following command to mark the package as deprecated in the NPM registry:
By using stylelint directly, we mean that Ember apps should tell their CI to run their
lint
script the same way it runs theirtest
script. The lint scripts in package.json usually look roughly like this in Ember apps (simplified version from ember-cli blueprint):More info:
eslint
andember-template-lint
directly (no longer lint during builds/rebuilds by default) ember-cli/ember-cli#9009