Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump nf core #52779

Merged
merged 7 commits into from
Jan 10, 2025
Merged

Bump nf core #52779

merged 7 commits into from
Jan 10, 2025

Conversation

mirpedrol
Copy link
Contributor

Update nf-core to 3.1.0
Replace #52760

@matthdsm matthdsm enabled auto-merge (squash) December 15, 2024 12:17
LouisLeNezet
LouisLeNezet reviewed Dec 21, 2024
View reviewed changes
Copy link
Contributor

@LouisLeNezet LouisLeNezet left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rocrate package seems to be available only through pip.
Would the following work ?

- pip
  - pip:
    - "rocrate"
    - "repo2rocrate"

@martin-g
Copy link
Contributor

Would the following work ?

No. Someone has to create a (Bio)Conda recipe for this dependency!

@LouisLeNezet
Copy link
Contributor

Everything is ready now 😄
Beware the PR #52826 is also doing the same bump !

@mirpedrol mirpedrol mentioned this pull request Jan 10, 2025
Closed
@ewels ewels mentioned this pull request Jan 10, 2025
Closed
@ewels
Copy link
Member

ewels commented Jan 10, 2025

I closed #52826 to avoid confusion.

Note that the other PR also changed prompt_toolkit to be >=3.0.48, which looks valid. Should also be applied here.

@matthdsm matthdsm merged commit 31cfa2e into bioconda:master Jan 10, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LouisLeNezet LouisLeNezet LouisLeNezet left review comments

@matthdsm matthdsm matthdsm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mirpedrol @martin-g @LouisLeNezet @ewels @matthdsm