Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add transaction type to panic message #207

Merged
merged 2 commits into from
Nov 27, 2024
Merged

Add transaction type to panic message #207

merged 2 commits into from
Nov 27, 2024

Conversation

ufoscout
Copy link
Contributor

Issue ticket

Issue ticket link: <>

Checklist before requesting a review

Code conventions

  • I have performed a self-review of my code
  • Every new function is documented
  • Object names are auto explicative

Security

  • The PR does not break APIs backward compatibility
  • The PR does not break the stable storage backward compatibility

Testing

  • Every function is properly unit tested
  • I have added integration tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • IC endpoints are always tested through the canister_call! macro

@ufoscout ufoscout changed the title epic Add transaction type to panic message Nov 22, 2024
@ufoscout ufoscout merged commit 6708eab into main Nov 27, 2024
3 checks passed
@ufoscout ufoscout deleted the test-tx-type branch November 27, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veeso veeso veeso approved these changes

@itsyaasir itsyaasir itsyaasir approved these changes

@Maximkaaa Maximkaaa Awaiting requested review from Maximkaaa

@F3kilo F3kilo Awaiting requested review from F3kilo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ufoscout @itsyaasir @veeso