-
-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add accounts to DB #1205
Draft
rfc2822
wants to merge
8
commits into
main-ose
Choose a base branch
from
934-create-accounts-table-in-db
base: main-ose
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Add accounts to DB #1205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rue SSOT for accounts
6 tasks
rfc2822
force-pushed
the
934-create-accounts-table-in-db
branch
from
December 30, 2024 17:03
a43d493
to
01a9013
Compare
This PR/issue depends on: |
rfc2822
force-pushed
the
934-create-accounts-table-in-db
branch
from
January 9, 2025 13:44
99d33b4
to
4ca0ef6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Previously, only system accounts (of type DAVx5 account) were used for everything account-related. However we had services in the database, which referenced to system accounts.
This PR adds accounts to the database to advance into a direction that allows us to have a reliable SSOT for accounts that is under our control (system accounts aren't).
In the scope of phase 1 (this PR), accounts will additionally be mirrored in the database, but system accounts remain the actual data source. In a future PR, this will be reversed: the database then becomes the actual data source and system accounts can be managed as required.
Short description
AccountRepository
the true SSOT for accounts (includes gettingAccount
s always overfromAccount(name)
).TODO:
account_type_test
is still neccesary → see https://github.com/bitfireAT/davx5-ose/tree/test-account-typeaccountRepository.fromName(service.accountName)
not necessary whenaccountName
is a foreign keyDepends on #1224
Checklist