Skip to content

Commit

Permalink
Merge pull request #588 from bitmovin/feature/prefix-css-animations
Browse files Browse the repository at this point in the history
Prefix css animations
  • Loading branch information
dweinber authored Nov 22, 2023
2 parents d4dd00e + d0559cd commit 403db84
Show file tree
Hide file tree
Showing 5 changed files with 17 additions and 12 deletions.
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,11 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](http://keepachangelog.com/)
and this project adheres to [Semantic Versioning](http://semver.org/).

## [Unreleased]

### Fixed
- Potential name clashing in CSS animations due to missing `bmpui` prefix

## [3.52.1] - 2023-11-13

### Fixed
Expand Down
4 changes: 2 additions & 2 deletions src/scss/skin-modern/components/_bufferingoverlay.scss
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
$buffering-animation-duration: 2s;
$buffering-animation-delay: $buffering-animation-duration * .1;

@keyframes fancy {
@keyframes #{$prefix}-fancy {
0% {
opacity: 0;
transform: scale(1);
Expand All @@ -63,7 +63,7 @@
}
}

animation: fancy $buffering-animation-duration ease-in infinite;
animation: #{$prefix}-fancy $buffering-animation-duration ease-in infinite;
background: url('../../assets/skin-modern/images/loader.svg') no-repeat center;
display: inline-block;
height: 2em;
Expand Down
4 changes: 2 additions & 2 deletions src/scss/skin-modern/components/_closebutton.scss
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
.#{$prefix}-ui-closebutton {
@extend %ui-button;

@keyframes pulsate {
@keyframes #{$prefix}-pulsate {
20% {
transform: scale(1.1);
}
Expand All @@ -27,6 +27,6 @@
&:hover {
@include svg-icon-shadow;

animation: pulsate 1s;
animation: #{$prefix}-pulsate 1s;
}
}
12 changes: 6 additions & 6 deletions src/scss/skin-modern/components/_hugeplaybacktogglebutton.scss
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
.#{$prefix}-ui-hugeplaybacktogglebutton {
@extend %ui-button;

@keyframes fade-out {
@keyframes #{$prefix}-fade-out {
from {
opacity: 1;
visibility: visible;
Expand All @@ -16,7 +16,7 @@
}
}

@keyframes fade-in {
@keyframes #{$prefix}-fade-in {
from {
opacity: 0;
transform: scale(2);
Expand All @@ -28,7 +28,7 @@
}
}

@keyframes breathe {
@keyframes #{$prefix}-breathe {
30% {
transform: scale(1.1);
}
Expand All @@ -53,21 +53,21 @@
width: 100%;

&:hover {
animation: breathe 3s ease-in-out infinite;
animation: #{$prefix}-breathe 3s ease-in-out infinite;
}
}

&.#{$prefix}-on {
.#{$prefix}-image {
animation: fade-out $animation-duration cubic-bezier(.55, .055, .675, .19); // http://easings.net/de#easeInCubic
animation: #{$prefix}-fade-out $animation-duration cubic-bezier(.55, .055, .675, .19); // http://easings.net/de#easeInCubic
transition: visibility 0s $animation-duration;
visibility: hidden;
}
}

&.#{$prefix}-off {
.#{$prefix}-image {
animation: fade-in $animation-duration cubic-bezier(.55, .055, .675, .19); // http://easings.net/de#easeInCubic
animation: #{$prefix}-fade-in $animation-duration cubic-bezier(.55, .055, .675, .19); // http://easings.net/de#easeInCubic
visibility: visible;
}
}
Expand Down
4 changes: 2 additions & 2 deletions src/scss/skin-modern/components/_hugereplaybutton.scss
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
height: 100%;
width: 100%;

@keyframes spin {
@keyframes #{$prefix}-spin {
50% {
transform: rotate(180deg) scale(1.1);
}
Expand All @@ -27,7 +27,7 @@
}

&:hover {
animation: spin .5s ease-in;
animation: #{$prefix}-spin .5s ease-in;
}
}
}

0 comments on commit 403db84

Please sign in to comment.