Skip to content

Commit

Permalink
Remove job id from the generated url
Browse files Browse the repository at this point in the history
  • Loading branch information
mukulmishra18 committed Jan 4, 2024
1 parent 09a4fbb commit 5b1924e
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
3 changes: 1 addition & 2 deletions .github/scripts/notifySlackTeam.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ const changelogPath = process.argv[3];
const releaseVersion = process.argv[4];
const slackWebhookUrl = process.argv[5];
const runId = process.argv[6];
const jobId = process.argv[7];

const slackChannelId = 'C06BYVC27QU'

Expand Down Expand Up @@ -36,7 +35,7 @@ function sendSlackMessage(slackChannelId, releaseVersion, changelogContent) {
if (jobStatus === 'success') {
message = `Changelog v${releaseVersion}\n${changelogContent}`
} else {
message = `Release v${releaseVersion} failed.\nPlease check https://github.com/bitmovin/bitmovin-player-ui/actions/runs/${runId}/job/${jobId}`
message = `Release v${releaseVersion} failed.\nPlease check https://github.com/bitmovin/bitmovin-player-ui/actions/runs/${runId}`
}

const sampleData = JSON.stringify({
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/tag-release-version.yml
Original file line number Diff line number Diff line change
Expand Up @@ -72,4 +72,4 @@ jobs:
- name: Notify failure
if: ${{ failure() }}
run: |
node .github/scripts/notifySlackTeam.js 'failure' 'CHANGELOG.md' '${{ fromJson(steps.define-release-version.outputs.result).full }}' ${{ secrets.RELEASE_FAILURE_SLACK_WEBHOOK }} ${{ github.run_number }} ${{ github.job }}
node .github/scripts/notifySlackTeam.js 'failure' 'CHANGELOG.md' '${{ fromJson(steps.define-release-version.outputs.result).full }}' ${{ secrets.RELEASE_FAILURE_SLACK_WEBHOOK }} ${{ github.run_id }}

0 comments on commit 5b1924e

Please sign in to comment.