Fix an exception when receiving a SourceLoaded event during scrubbing.
#585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stonko1994
commented
Nov 13, 2023
| @@ -254,7 +254,7 @@ export class SeekBar extends Component<SeekBarConfig> { | |||
| // At the same time when the user is scrubbing, we also move the position of the seekbar to display a preview during scrubbing. | |||
| // When the user is scrubbing we do not record this as a user seek operation, as the user has yet to finish their seek, | |||
| // but we should not move the playback position to not create a jumping behaviour. | |||
| if (scrubbing && event.type === player.exports.PlayerEvent.SegmentRequestFinished && playbackPositionPercentage !== this.playbackPositionPercentage) { | |||
| if (scrubbing && event && event.type === player.exports.PlayerEvent.SegmentRequestFinished && playbackPositionPercentage !== this.playbackPositionPercentage) { | |||
There was a problem hiding this comment.
The event is optional and even null per default. However, it's not checked if it's null (This is the only usage of this property here)
wasp898
approved these changes
Nov 13, 2023
wasp898
reviewed
Nov 13, 2023
Co-authored-by: Giuseppe Samela <[email protected]>
stonko1994
deleted the
feature/fix-exception-when-loading-a-new-source-while-scrubbing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When the
playbackPositionHandlerinside theSeekbaris called without an event (i.e., withnull), such as during the reception of aSourceLoadedevent, the application crashes. This leads to an undefined UI state where theseekbaris partially updated to the player state, and the play button may be missing.Changes
Adding the missing
nullcheck for the optional event parameter.