Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor small screen layout improvements #659

Merged
merged 10 commits into from
Dec 20, 2024
2 changes: 1 addition & 1 deletion src/scss/skin-modern/_skin.scss
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@import 'variables';

Check warning on line 1 in src/scss/skin-modern/_skin.scss

View workflow job for this annotation

GitHub Actions / test_and_build

Space expected between blocks
.#{$prefix}-ui-skin-modern {
@import 'mixins';
@import 'components/component';
Expand Down Expand Up @@ -51,7 +51,7 @@
@import 'skin-smallscreen';
@import 'skin-tv';

.#{$prefix}-ui-uicontainer {
&.#{$prefix}-ui-uicontainer {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This went unnoticed as some of the general styles are handled by the player itself.

color: $color-primary;
font-family: $font-family;
font-size: $font-size;
Expand All @@ -59,7 +59,7 @@
user-select: none;

&.#{$prefix}-player-state-idle {
.#{$prefix}-ui-controlbar,

Check warning on line 62 in src/scss/skin-modern/_skin.scss

View workflow job for this annotation

GitHub Actions / test_and_build

Nesting depth 3 greater than max of 2
.#{$prefix}-ui-titlebar,
.#{$prefix}-ui-hugeplaybacktogglebutton {
display: none;
Expand All @@ -67,7 +67,7 @@
}

&.#{$prefix}-player-state-finished {
.#{$prefix}-ui-controlbar,

Check warning on line 70 in src/scss/skin-modern/_skin.scss

View workflow job for this annotation

GitHub Actions / test_and_build

Nesting depth 3 greater than max of 2
.#{$prefix}-ui-hugeplaybacktogglebutton {
display: none;
}
Expand Down
36 changes: 6 additions & 30 deletions src/scss/skin-super-modern/_skin-modern-smallscreen.scss
Original file line number Diff line number Diff line change
Expand Up @@ -63,36 +63,12 @@

// Adjustments for screen width x <= 400
&.#{$prefix}-layout-max-width-400 {
.#{$prefix}-ui-settings-panel,
.#{$prefix}-ui-hugeplaybacktogglebutton,
.#{$prefix}-ui-smallcenteredplaybacktogglebutton,
.#{$prefix}-ui-hugereplaybutton,
.#{$prefix}-ui-errormessage-overlay,
.#{$prefix}-ui-buffering-overlay,
.#{$prefix}-ui-subtitle-overlay,
.#{$prefix}-ui-cast-status-overlay {
font-size: .6em;
.#{$prefix}-ui-settings-panel {
left: 1em;
right: 1em;

Check warning on line 68 in src/scss/skin-super-modern/_skin-modern-smallscreen.scss

View workflow job for this annotation

GitHub Actions / test_and_build

Expected `margin-top`, found `right`
margin-top: 3.5em;

Check warning on line 69 in src/scss/skin-super-modern/_skin-modern-smallscreen.scss

View workflow job for this annotation

GitHub Actions / test_and_build

Expected `max-height`, found `margin-top`
max-height: calc(100% - 3.5em - 3.5em);

Check warning on line 70 in src/scss/skin-super-modern/_skin-modern-smallscreen.scss

View workflow job for this annotation

GitHub Actions / test_and_build

Expected `right`, found `max-height`
width: unset;
}
}

// Adjustments for screen width 400 < x <= 600
&.#{$prefix}-layout-max-width-600 {
.#{$prefix}-ui-settings-panel,
.#{$prefix}-ui-hugeplaybacktogglebutton,
.#{$prefix}-ui-smallcenteredplaybacktogglebutton,
.#{$prefix}-ui-hugereplaybutton,
.#{$prefix}-ui-errormessage-overlay,
.#{$prefix}-ui-buffering-overlay,
.#{$prefix}-ui-subtitle-overlay,
.#{$prefix}-ui-cast-status-overlay {
font-size: .8em;
}
}

// Adjustments for screen width x <= 600
// sass-lint:disable no-empty-rulesets
&.#{$prefix}-layout-max-width-400,
&.#{$prefix}-layout-max-width-600 {
// none yet
}
}
2 changes: 1 addition & 1 deletion src/scss/skin-super-modern/_skin.scss
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
@import 'skin-tv';

// sass-lint:disable nesting-depth
.#{$prefix}-ui-uicontainer {
&.#{$prefix}-ui-uicontainer {
color: $color-primary;
font-family: $font-family;
font-size: $font-size;
Expand Down
1 change: 1 addition & 0 deletions src/scss/skin-super-modern/components/_button.scss
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
min-width: 1.5em;
padding: .25em;
transition: transform .15s ease;
-webkit-tap-highlight-color: transparent;

.#{$prefix}-label {
color: $color-primary;
Expand Down
1 change: 1 addition & 0 deletions src/scss/skin-super-modern/components/_label.scss
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@

cursor: default;
white-space: nowrap;
-webkit-tap-highlight-color: transparent;
}

.#{$prefix}-ui-label {
Expand Down
2 changes: 2 additions & 0 deletions src/scss/skin-super-modern/components/_settingspanel.scss
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,11 @@

$background-color: transparentize($color-background-menu, .15);

backdrop-filter: blur(10px);
background-color: $background-color;
border-radius: 4px;
bottom: 3.5em;
box-shadow: 0 0 3px 0 transparentize($color: #000, $amount: .75);
height: fit-content;
max-height: 60%;
min-width: fit-content;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,12 +1,7 @@
@import '../variables';
@import '../mixins';

// sass-lint:disable no-vendor-prefixes
%opacity-transition {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor cleanup.

-moz-transition: opacity .25s ease;
-ms-transition: opacity .25s ease;
-o-transition: opacity .25s ease;
-webkit-transition: opacity .25s ease;
transition: opacity .25s ease-out;
}

Expand Down
Loading