Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bitnami/mysql] Optimize MYSQL_REPLICATION_SLAVE_DUMP behavior #76221

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[bitnami/mysql] Optimize MYSQL_REPLICATION_SLAVE_DUMP behavior #76221

wants to merge 1 commit into from
+11 −9

Conversation

mostafa-rz
Copy link

@mostafa-rz mostafa-rz commented Jan 13, 2025 •
edited
Loading

Description of the change

  • Remove obtain and release the database lock
  • Remove finding binlog file name and current position
  • Add new options to the mysqldump
    • --single-transaction to dump consistent data
    • --quick to deal with large tables
    • --source-data=2 to add binlog file name and current position as a comment to the dump file
  • Add searching the dump file to find the binlog file name and current position

Benefits

The source database snapshot is consistent.

Applicable issues

@github-actions github-actions bot added mysql triage Triage is needed labels Jan 13, 2025
@github-actions github-actions bot requested a review from carrodher January 13, 2025 09:42
@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels Jan 13, 2025
@github-actions github-actions bot removed the triage Triage is needed label Jan 13, 2025
@github-actions github-actions bot removed the request for review from carrodher January 13, 2025 11:48
@github-actions github-actions bot requested a review from fmulero January 13, 2025 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmulero fmulero Awaiting requested review from fmulero

At least 1 approving review is required to merge this pull request.

Assignees

@fmulero fmulero

Labels
in-progress mysql verify Execute verification workflow for these changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optimize MYSQL_REPLICATION_SLAVE_DUMP behavior
3 participants
@mostafa-rz @carrodher @fmulero