Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Named Sets and toggle for Set exercise visiblity #201

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Named Sets and toggle for Set exercise visiblity #201

wants to merge 6 commits into from

Conversation

crimsoncor
Copy link

A couple small quality of life changes as I learn dart and flutter.

  1. Add a way to give a name to a set. Currently this is triggered via a long-press on the ListTile which contains the set name using a flutter prompt dialog. I considered making the set name a live text field, like the workout name, but the set editing interface is already busy and I didn't want to add something else that a user could accidentally click on. I don't love that the edit facility is now not easily discoverable, though. I played with adding an edit button but no matter where I put it, it really messed with the layout of the ListTile. Open to other and better suggestions for this.

Set names are saved to json and show up in the workout runner. I limited them to 15 characters, but even at that length, they can push the timer in the workout builder onto a new line, so I just permanent split the set name and the timer onto separate lines. I also dropped the font size slightly on the set name.

  1. Add a way to hide the exercise list for a set in the workout builder. Makes it much easier to re-ordered sets or to just concentrate on the current set being built. Since this is just UI sugar, I did not persist it to JSON. I also purposely did not copy it when duplicating a set. This way, you can use a workflow where you make a set, collapse its exercises, duplicate it, and then immediately be ready to edit the new set. This also necessitated fixing a small bug where a duplicated set was being inserted before the current set. It wasn't noticeable before sets could be collapsed, but it is now.

@crimsoncor
Copy link
Author

Screen shots of the new features.
Screenshot_20240425_110535
Screenshot_20240425_111640
Screenshot_20240425_111706
Screenshot_20240425_111720
Screenshot_20240425_111745

Jesse and others added 5 commits July 12, 2024 11:05
@crimsoncor
Get a basic set name feature working for workout editor
fa973da
@crimsoncor
Fix a bug where a duplicated set was inserted before the current set
1cb44a0 
This wasn't noticeable until I added the ability to collapse sets, but
once that was added, it mattered where exactly the new set was inserted
@crimsoncor
Finish work on the set name feature
9d777f4 
To rename a set, you can long-press on the name of the set in the
builder.

In order to deal with the new variable length set names, I broke the set
name and workout duration into two separate lines in the workout runner.
I don't love having to eat up more vertical space that way, but don't
have another amazing idea for how to deal with it and I didn't want to
shrink down the font size
@crimsoncor
Add the ability to hide a set's list of exercises in the builder
db1927a 
Makes re-organizing sets much easier and lets you focus on just the
current set you're making
@crimsoncor
Cleanup the whitespace and formatting to match main
9660348
@crimsoncor
Add the prompt_dialog dependency
a8c163f 
Got removed when rebasing
@crimsoncor
Copy link
Author

@blockbasti would it be possible to get a review/notes/approval on this PR? cheers, jesse

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@crimsoncor