Skip to content
This repository has been archived by the owner on Mar 7, 2023. It is now read-only.

New mdid #368

Open
wants to merge 48 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
48 commits
Select commit Hold shift + click to select a range
ed6c030
feaat(metadata): compatible with new version of the metadata service
sha49 Nov 22, 2016
0d1118b
feat(shared Metadata): basic functionality
sha49 Nov 22, 2016
8cdc29a
feat(shared Metadata): contacts and sharedMetadata
sha49 Nov 22, 2016
8f9f2c3
test(External): fixed interference with coinify_trade_spec
Sjors Nov 24, 2016
b26107a
feat(shared Metadata): extracted API
sha49 Nov 28, 2016
5ace804
feat(contacts): messaging available
sha49 Nov 30, 2016
ea5d55c
feat(mdid): guid-mdid registration
sha49 Dec 6, 2016
ce70ed2
feat(readInvitation): returns the newly created contact.
sha49 Dec 6, 2016
d9a8640
fix(sharedMetadata): require metadata
kwgithubusername Dec 7, 2016
b87506b
feat(relation): simplified method
sha49 Jan 4, 2017
4be98ef
feat(payment requests)
sha49 Jan 13, 2017
1ade631
feat(PR): payment request address non-reused.
sha49 Jan 16, 2017
6d2736e
fix(digest messages) should wait for all the messages to be digested.
sha49 Jan 26, 2017
02bd491
feat(PR): gap cannot be exceed
sha49 Feb 13, 2017
9fba3b9
feat(Contacts): add last_updated field (#331)
kwgithubusername Feb 15, 2017
7ed7927
typo
sha49 Feb 15, 2017
f814356
fix(): do not mix import styles
sha49 Feb 15, 2017
412ffde
tests(): facilitatedTx and Contact
sha49 Feb 17, 2017
a8ceadd
test()
sha49 Feb 17, 2017
b0e037f
tests(contact class)
sha49 Feb 17, 2017
cf326ee
tests(): contacts_spec
sha49 Feb 17, 2017
32a766e
tests(): contacts_spec
sha49 Feb 17, 2017
bda40ba
fix(lastUpdated): typo
sha49 Feb 20, 2017
7e6fe2d
tests(contacts)
sha49 Feb 20, 2017
8789a3b
more tests
sha49 Feb 21, 2017
273979c
Merge branch 'master' into new-mdid
sha49 Feb 21, 2017
eedab45
feat(digest): returns a promise of all the digested messages
sha49 Feb 21, 2017
cdde251
fix(requests): created and last_updated handling
sha49 Feb 22, 2017
5c3421d
fixed broken tests
sha49 Feb 22, 2017
e8e9002
PRR diesgtion test
sha49 Feb 23, 2017
4ec9f47
feat(requests): cancel and decline support
sha49 Mar 21, 2017
ef36ea7
fix(SharedMetadataAPI): pass JSON container to /share endpoint
kwgithubusername Apr 4, 2017
e29466f
partial contacts-request
sha49 Apr 12, 2017
a96638d
Merge branch 'master' into new-mdid
sha49 Apr 18, 2017
cddad6c
Merge branch 'master' into new-mdid
sha49 Jun 13, 2017
ce0347a
fix partial
sha49 Jun 13, 2017
3cf6642
chore(Build): fix paths to js files
kwgithubusername Jun 13, 2017
07b1ebe
fix(sharedMetadataAPI): update service name
kwgithubusername Jun 13, 2017
5cefda8
fix(Contacts): use label service
kwgithubusername Jun 13, 2017
119d9d8
feat(Contacts): store sender name
kwgithubusername Jun 30, 2017
3e7fe80
feat(Contacts): add initiator source (selected account/imported addre…
kwgithubusername Jul 26, 2017
b16f9d1
feat(Contacts): allow only HD accounts for initiator source
kwgithubusername Jul 26, 2017
2b0be17
fix(Contacts): use decline function in digestDecline
kwgithubusername Jul 28, 2017
ad257f8
Revert "feat(Contacts): store sender name"
kwgithubusername Aug 1, 2017
3402f60
clean(Contacts): remove initiator source except for sending PR from s…
kwgithubusername Aug 1, 2017
8a9a1a9
feat(Contacts): do not change role of PR on digestion if request alre…
kwgithubusername Aug 1, 2017
e0d4ecf
feat(Contacts): expose uuid function for iOS to override
kwgithubusername Aug 2, 2017
836329b
Revert "feat(Contacts): expose uuid function for iOS to override"
kwgithubusername Aug 4, 2017
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/contact.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ class Contact {
this.id = o.id;
this.mdid = o.mdid;
this.name = o.name;
this.senderName = o.senderName;
Copy link
Contributor Author

@sha49 sha49 Aug 1, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need that? I think android is just asking for the name you want to share every time you invite somebody. The less extra information we have on the facilitated tx list the better. Actually, if you want to save somewhere your own name you should not do it on the TX, it might be a settings of contacts or your application

Copy link
Contributor

@kwgithubusername kwgithubusername Aug 1, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I will just do what Android does. I will also remove initiator_source since mobile teams also decided to not use that.

this.xpub = o.xpub;
this.trusted = o.trusted;
this.invitationSent = o.invitationSent; // I invited somebody
Expand Down