This repository has been archived by the owner on Mar 7, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 284
New mdid #368
Open
sha49
wants to merge
48
commits into
master
Choose a base branch
from
new-mdid
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
New mdid #368
Changes from 1 commit
Commits
Show all changes
48 commits
Select commit
Hold shift + click to select a range
ed6c030
feaat(metadata): compatible with new version of the metadata service
sha49 0d1118b
feat(shared Metadata): basic functionality
sha49 8cdc29a
feat(shared Metadata): contacts and sharedMetadata
sha49 8f9f2c3
test(External): fixed interference with coinify_trade_spec
Sjors b26107a
feat(shared Metadata): extracted API
sha49 5ace804
feat(contacts): messaging available
sha49 ea5d55c
feat(mdid): guid-mdid registration
sha49 ce70ed2
feat(readInvitation): returns the newly created contact.
sha49 d9a8640
fix(sharedMetadata): require metadata
kwgithubusername b87506b
feat(relation): simplified method
sha49 4be98ef
feat(payment requests)
sha49 1ade631
feat(PR): payment request address non-reused.
sha49 6d2736e
fix(digest messages) should wait for all the messages to be digested.
sha49 02bd491
feat(PR): gap cannot be exceed
sha49 9fba3b9
feat(Contacts): add last_updated field (#331)
kwgithubusername 7ed7927
typo
sha49 f814356
fix(): do not mix import styles
sha49 412ffde
tests(): facilitatedTx and Contact
sha49 a8ceadd
test()
sha49 b0e037f
tests(contact class)
sha49 cf326ee
tests(): contacts_spec
sha49 32a766e
tests(): contacts_spec
sha49 bda40ba
fix(lastUpdated): typo
sha49 7e6fe2d
tests(contacts)
sha49 8789a3b
more tests
sha49 273979c
Merge branch 'master' into new-mdid
sha49 eedab45
feat(digest): returns a promise of all the digested messages
sha49 cdde251
fix(requests): created and last_updated handling
sha49 5c3421d
fixed broken tests
sha49 e8e9002
PRR diesgtion test
sha49 4ec9f47
feat(requests): cancel and decline support
sha49 ef36ea7
fix(SharedMetadataAPI): pass JSON container to /share endpoint
kwgithubusername e29466f
partial contacts-request
sha49 a96638d
Merge branch 'master' into new-mdid
sha49 cddad6c
Merge branch 'master' into new-mdid
sha49 ce0347a
fix partial
sha49 3cf6642
chore(Build): fix paths to js files
kwgithubusername 07b1ebe
fix(sharedMetadataAPI): update service name
kwgithubusername 5cefda8
fix(Contacts): use label service
kwgithubusername 119d9d8
feat(Contacts): store sender name
kwgithubusername 3e7fe80
feat(Contacts): add initiator source (selected account/imported addre…
kwgithubusername b16f9d1
feat(Contacts): allow only HD accounts for initiator source
kwgithubusername 2b0be17
fix(Contacts): use decline function in digestDecline
kwgithubusername ad257f8
Revert "feat(Contacts): store sender name"
kwgithubusername 3402f60
clean(Contacts): remove initiator source except for sending PR from s…
kwgithubusername 8a9a1a9
feat(Contacts): do not change role of PR on digestion if request alre…
kwgithubusername e0d4ecf
feat(Contacts): expose uuid function for iOS to override
kwgithubusername 836329b
Revert "feat(Contacts): expose uuid function for iOS to override"
kwgithubusername File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need that? I think android is just asking for the name you want to share every time you invite somebody. The less extra information we have on the facilitated tx list the better. Actually, if you want to save somewhere your own name you should not do it on the TX, it might be a settings of contacts or your application
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok I will just do what Android does. I will also remove
initiator_source
since mobile teams also decided to not use that.