Skip to content

Commit

Permalink
Bring back ReportEndVerifyImplementation (#705)
Browse files Browse the repository at this point in the history
  • Loading branch information
keyboardDrummer authored Mar 9, 2023
1 parent 5af8ea2 commit 6f2d102
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 5 deletions.
2 changes: 1 addition & 1 deletion Source/Directory.Build.props
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<!-- Target framework and package configuration -->
<PropertyGroup>
<Version>2.16.2</Version>
<Version>2.16.3</Version>
<TargetFramework>net6.0</TargetFramework>
<GeneratePackageOnBuild>false</GeneratePackageOnBuild>
<Authors>Boogie</Authors>
Expand Down
8 changes: 5 additions & 3 deletions Source/ExecutionEngine/ExecutionEngine.cs
Original file line number Diff line number Diff line change
Expand Up @@ -831,9 +831,11 @@ private IObservable<IVerificationStatus> VerifyImplementation(
var afterRunningStates = VerifyImplementationWithoutCaching(processedProgram, stats, er, cancellationToken,
programId, implementation, traceWriter).Do(status =>
{
if (status is Completed completed && 0 < Options.VerifySnapshots && !string.IsNullOrEmpty(implementation.Checksum))
{
Cache.Insert(implementation, completed.Result);
if (status is Completed completed) {
if (0 < Options.VerifySnapshots && !string.IsNullOrEmpty(implementation.Checksum)) {
Cache.Insert(implementation, completed.Result);
}
Options.Printer.ReportEndVerifyImplementation(implementation, completed.Result);
}
});
return Observable.Return(new Running()).Concat(afterRunningStates);
Expand Down
1 change: 1 addition & 0 deletions Source/ExecutionEngine/OutputPrinter.cs
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,5 @@ public interface OutputPrinter
void WriteTrailer(TextWriter textWriter, PipelineStatistics stats);
void WriteErrorInformation(ErrorInformation errorInfo, TextWriter tw, bool skipExecutionTrace = true);
void ReportBplError(IToken tok, string message, bool error, TextWriter tw, string category = null);
void ReportEndVerifyImplementation(Implementation implementation, VerificationResult result);
}
6 changes: 5 additions & 1 deletion Source/UnitTests/ExecutionEngineTests/NullPrinter.cs
Original file line number Diff line number Diff line change
Expand Up @@ -29,4 +29,8 @@ public void WriteErrorInformation(ErrorInformation errorInfo, TextWriter tw, boo

public void ReportBplError(IToken tok, string message, bool error, TextWriter tw, string category = null) {
}
}

public void ReportEndVerifyImplementation(Implementation implementation, VerificationResult result)
{
}
}

0 comments on commit 6f2d102

Please sign in to comment.