implement inlining for call attributes #980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atomb
previously approved these changes
Nov 7, 2024
Source/Core/Inline.cs
Outdated
|
|
||
| public int getDepth(Implementation impl) { | ||
| var procName = getName(impl); | ||
| var c = -1; |
There was a problem hiding this comment.
I think this line is redundant. You could probably use out var c in the line below and leave this line out.
There was a problem hiding this comment.
Oh i didn't know that writing out var c defines c.
atomb
approved these changes
Nov 8, 2024
| protected Dictionary<string, int> procUnrollDepth = new(); | ||
| protected Dictionary<string, CallCmd> procUnrollSrc = new(); | ||
|
|
||
| private string getName (Implementation impl) { |
There was a problem hiding this comment.
Please remove the redundant space and use PascalCase for method names, as is the C# convention. If you use a C# IDE then it'll alert you to the incorrect name. We should add a stylistic checker to the Boogie CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements support for inlining based on call sites, while maintaining the behavior of inlining based on procedure definitions. When there is a clash, the inlining depth specified at the call site "wins", because its more precise.
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.