Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add find_first(offset) method #81

Closed
wants to merge 19 commits into from
Closed

Conversation

Siapran
Copy link
Contributor

@Siapran Siapran commented Nov 18, 2024

See #80.

@jeking3
Copy link
Collaborator

jeking3 commented Nov 20, 2024

The CI in this repo might not have run properly for a while - not sure, let's see how the tests go.

@jeking3
Copy link
Collaborator

jeking3 commented Nov 20, 2024

Yuck... all the CI still includes C++03 which most of boost no longer supports. I bet many of the community maintained repositories are suffering from this...

@Siapran
Copy link
Contributor Author

Siapran commented Nov 22, 2024

what needs to be done then?

@jeking3
Copy link
Collaborator

jeking3 commented Nov 25, 2024

I fixed the CI today, rebase this PR so we can run the tests again.

@jeking3 jeking3 self-assigned this Nov 25, 2024
@Siapran
Copy link
Contributor Author

Siapran commented Nov 26, 2024

oh god don't tell me I rebased the wrong way round.

@jeking3
Copy link
Collaborator

jeking3 commented Nov 26, 2024

Something doesn't look quite right there...

@Siapran
Copy link
Contributor Author

Siapran commented Nov 26, 2024

...I might just redo this PR, I've no idea what I did wrong with git

@jeking3
Copy link
Collaborator

jeking3 commented Nov 26, 2024

You can typically use git reflog to find your code commit(s) before the rebase.

@Siapran
Copy link
Contributor Author

Siapran commented Nov 26, 2024

I cherry picked all the commits I made and combined them into this new branch, there wasn't anything terribly interesting going on in those steps.

@Siapran Siapran closed this Nov 26, 2024
@Siapran Siapran deleted the find-offset branch November 26, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants