-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix node 20 issue on GHA CI #758
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #758 +/- ##
===========================================
+ Coverage 82.12% 82.46% +0.34%
===========================================
Files 117 117
Lines 5355 5727 +372
===========================================
+ Hits 4398 4723 +325
- Misses 957 1004 +47 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @Flamefire
The failing Mac OS job seems unrelated to the Node fixes:
testing.capture-output bin.v2/libs/gil/test/core/image/image.test/clang-darwin-15/debug/x86_64/cxxstd-17-iso/threading-multi/visibility-hidden/image.run
/bin/sh: line 4: 17731 Abort trap: 6 "bin.v2/libs/gil/test/core/image/image.test/clang-darwin-15/debug/x86_64/cxxstd-17-iso/threading-multi/visibility-hidden/image" > "bin.v2/libs/gil/test/core/image/image.test/clang-darwin-15/debug/x86_64/cxxstd-17-iso/threading-multi/visibility-hidden/image.output" 2>&1 < /dev/null
====== BEGIN OUTPUT ======
dyld[17731]: Symbol not found: __ZNSt3__13pmr20get_default_resourceEv
Referenced from: <DB80F50C-E469-3DF2-A4D7-AD21DD4B429C> /Users/runner/work/gil/boost-root/bin.v2/libs/gil/test/core/image/image.test/clang-darwin-15/debug/x86_64/cxxstd-17-iso/threading-multi/visibility-hidden/image
Expected in: <8CAC377D-FCC3-34DD-8FA6-C76EBB4D68C9> /usr/lib/libc++.1.dylib
EXIT STATUS: 134
====== END OUTPUT ======
DYLD_LIBRARY_PATH="/Users/runner/work/gil/boost-root/bin.v2/libs/atomic/build/clang-darwin-15/debug/x86_64/cxxstd-17-iso/threading-multi/visibility-hidden:/Users/runner/work/gil/boost-root/bin.v2/libs/filesystem/build/clang-darwin-15/debug/x86_64/cxxstd-17-iso/threading-multi/visibility-hidden:/Users/runner/work/gil/boost-root/bin.v2/libs/system/build/clang-darwin-15/debug/x86_64/cxxstd-17-iso/threading-multi/visibility-hidden:$DYLD_LIBRARY_PATH"
export DYLD_LIBRARY_PATH
"bin.v2/libs/gil/test/core/image/image.test/clang-darwin-15/debug/x86_64/cxxstd-17-iso/threading-multi/visibility-hidden/image" > "bin.v2/libs/gil/test/core/image/image.test/clang-darwin-15/debug/x86_64/cxxstd-17-iso/threading-multi/visibility-hidden/image.output" 2>&1 < /dev/null
status=$?
echo >> "bin.v2/libs/gil/test/core/image/image.test/clang-darwin-15/debug/x86_64/cxxstd-17-iso/threading-multi/visibility-hidden/image.output"
echo EXIT STATUS: $status >> "bin.v2/libs/gil/test/core/image/image.test/clang-darwin-15/debug/x86_64/cxxstd-17-iso/threading-multi/visibility-hidden/image.output"
if test $status -eq 0 ; then
cp "bin.v2/libs/gil/test/core/image/image.test/clang-darwin-15/debug/x86_64/cxxstd-17-iso/threading-multi/visibility-hidden/image.output" "bin.v2/libs/gil/test/core/image/image.test/clang-darwin-15/debug/x86_64/cxxstd-17-iso/threading-multi/visibility-hidden/image.run" >/dev/null
fi
verbose=0
if test $status -ne 0 ; then
verbose=1
fi
if test $verbose -eq 1 ; then
echo ====== BEGIN OUTPUT ======
cat "bin.v2/libs/gil/test/core/image/image.test/clang-darwin-15/debug/x86_64/cxxstd-17-iso/threading-multi/visibility-hidden/image.output"
echo ====== END OUTPUT ======
fi
exit $status
...failed testing.capture-output bin.v2/libs/gil/test/core/image/image.test/clang-darwin-15/debug/x86_64/cxxstd-17-iso/threading-multi/visibility-hidden/image.run...
So, I'm merging this PR as successful.
Description
References
Tasklist