Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable include hidden #627

Merged
merged 5 commits into from
Jan 16, 2022
Merged

Enable include hidden #627

merged 5 commits into from
Jan 16, 2022

Conversation

a5-stable
Copy link
Contributor

Fixes #215

Enable include_hidden option with collection_check_boxes:

@donv
Copy link
Collaborator

donv commented Jan 14, 2022

This PR looks good, but the "danger" linting fails. Anybody an idea why the linting fails?

@donv
Copy link
Collaborator

donv commented Jan 14, 2022

This might be the problem: danger/danger#1103

@a5-stable
Copy link
Contributor Author

a5-stable commented Jan 15, 2022

Thanks for checking!

#625 seems to mention this failure.

@donv
Copy link
Collaborator

donv commented Jan 15, 2022

I have committed the suggested fix for danger. @a5-stable could you rebase this PR to test the fix?

@a5-stable
Copy link
Contributor Author

@donv
Thank you for quick fixing.
Synced to HEAD.

@donv
Copy link
Collaborator

donv commented Jan 16, 2022

I committed a workflow change to enable secrets for fork-PRs for danger. Could you rebase again and see if it helps? If it doesn't help I will do a manual review of this PR.

@a5-stable
Copy link
Contributor Author

@donv
Thanks!
I did but workflow seems failed at loading danger.

@donv
Copy link
Collaborator

donv commented Jan 16, 2022

Thanks @a5-stable for the PR and the CHANGELIG entry! The problem with danger will take longer to resolve, so I'll merge this PR now.

@donv donv merged commit c07c482 into bootstrap-ruby:main Jan 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unwanted hidden input on check_box helper with bootstrap_form_tag
2 participants