Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't always run php for DPP_CORO #1363

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Conversation

supsm
Copy link
Contributor

@supsm supsm commented Jan 20, 2025

If DPP_CORO is configured to be true, the make_struct.php will always be run, even if not on UNIX or if PHP isn't found. This PR moves the relevant execute_process to where the other php files are run.

(and no, I'm not able to retarget or reopen the other PR)

Code change checklist

  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • My code follows the coding style guide.
  • I tested that my change works before raising the PR.
  • I have ensured that I did not break any existing API calls.
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

Copy link

netlify bot commented Jan 20, 2025

Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit d11ec12
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/678df238a5f94e0008030d3f
😎 Deploy Preview https://deploy-preview-1363--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the build Issue or Pull Request related to the build process label Jan 20, 2025
@braindigitalis
Copy link
Contributor

thanks for the contribution :)

@braindigitalis braindigitalis merged commit 9c16057 into brainboxdotcc:dev Jan 20, 2025
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issue or Pull Request related to the build process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants