Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: rename geminix test #2271

Merged
merged 1 commit into from
Dec 21, 2023
Merged

refactor: rename geminix test #2271

merged 1 commit into from
Dec 21, 2023

Conversation

clD11
Copy link
Contributor

@clD11 clD11 commented Dec 20, 2023

Summary

Rename tests

Type of Change

  • Product feature
  • Bug fix
  • Performance improvement
  • Refactor
  • Other

Tested Environments

  • Development
  • Staging
  • Production

Before Requesting Review

  • Does your code build cleanly without any errors or warnings?
  • Have you used auto closing keywords?
  • Have you added tests for new functionality?
  • Have validated query efficiency for new database queries?
  • Have documented new functionality in README or in comments?
  • Have you squashed all intermediate commits?
  • Is there a clear title that explains what the PR does?
  • Have you used intuitive function, variable and other naming?
  • Have you requested security and/or privacy review if needed
  • Have you performed a self review of this PR?

Manual Test Plan

@clD11 clD11 self-assigned this Dec 20, 2023
@clD11 clD11 requested a review from pavelbrm December 20, 2023 14:38
@github-actions GitHub Actions
Copy link

The following commits were not verified:
21f0a4a (unsigned)

pavelbrm
pavelbrm approved these changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@pavelbrm pavelbrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! 👍

@clD11 clD11 merged commit ac70def into master Dec 21, 2023
12 checks passed
@clD11 clD11 deleted the rename-tests branch December 21, 2023 10:12
@hspencer77 hspencer77 mentioned this pull request Mar 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavelbrm pavelbrm pavelbrm approved these changes

Assignees

@clD11 clD11

Labels
unverified-commits
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clD11 @pavelbrm